Attention is currently required from: Paul Menzel, Rex-BC Chen.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55051 )
Change subject: soc/mediatek: Initialize SSPM
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55051/comment/a8118fd0_d7c20e59
PS2, Line 11: TEST=none
Please do, and add how much time it adds to the boot.
@Rex can you at least make sure the device still boots?
File src/soc/mediatek/mt8195/Kconfig:
https://review.coreboot.org/c/coreboot/+/55051/comment/97a50857_f6c2e30f
PS2, Line 32: The file name of the MediaTek SSPM firmware.
Maybe add in what path the file is expected in.
I'm not sure if that's needed, since most files in CBFS are in top level (root folder); this should be clear enough right?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55051
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia227ea9f7d58129068cb36ec2de7d9feb677006b
Gerrit-Change-Number: 55051
Gerrit-PatchSet: 3
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Tue, 01 Jun 2021 08:29:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment