Hello Hung-Te Lin, build bot (Jenkins), Joel Kitching, Raul Rangel, Patrick Georgi, Martin Roth, Nick Vaccaro, Julius Werner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39390
to look at the new patch set (#7).
Change subject: cbfstool: Build vboot library ......................................................................
cbfstool: Build vboot library
Currently cbfstool cherry-picks a few files from vboot and hopes these files will work standalone without any dependencies. This is pretty brittle (for example, CL:2084062 will break it), and could be improved by building the whole vboot library and then linking against it. Therefore, this patch creates a new target $(VBOOT_HOSTLIB) and includes it as a dependency for cbfstool and ifittool.
To prevent building the vboot lib twice (one for cbfstool and the other for futility) when building coreboot tools together, add the variable 'VBOOT_BUILD' in Makefile to define a shared build path among different tools so that vboot files don't need to be recompiled.
Also add vboot_lib/ to .gitignore.
BRANCH=none BUG=none TEST=make -C util/cbfstool TEST=make -C util/futility TEST=Run 'make tools' and make sure common files such as 2sha1.c are compiled only once TEST=emerge-nami coreboot-utils
Change-Id: Ifc826896d895f53d69ea559a88f75672c2ec3146 Signed-off-by: Yu-Ping Wu yupingso@chromium.org --- M .gitignore M Makefile M util/cbfstool/Makefile M util/cbfstool/Makefile.inc M util/futility/Makefile M util/futility/Makefile.inc 6 files changed, 36 insertions(+), 24 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/39390/7