chris wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45334 )
Change subject: mb/google/zork: Set USB3 typeA port to force gen1 for morphius
......................................................................
Patch Set 14:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45334/8/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/morphius/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45334/8/src/mainboard/google/zork/v...
PS8, Line 26: register "usb3_port_force_gen1" = "0x6" #0110b
The USB3A port needs set to Gen1 since it's not gonna support Gen2. […]
Done
https://review.coreboot.org/c/coreboot/+/45334/6/src/soc/amd/picasso/chip.h
File src/soc/amd/picasso/chip.h:
https://review.coreboot.org/c/coreboot/+/45334/6/src/soc/amd/picasso/chip.h@...
PS6, Line 171: uint32_t usb3_port_force_gen1;
it's a rebase mistake. It should been added in another change. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45334
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I10419b91fe86fe3e06de36ddfe0d1769c1031f8e
Gerrit-Change-Number: 45334
Gerrit-PatchSet: 14
Gerrit-Owner: chris wang
Chris.Wang@amd.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Keith Tzeng
keith.tzeng@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 28 Sep 2020 05:37:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Comment-In-Reply-To: chris wang
Chris.Wang@amd.com
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment