Attention is currently required from: Kapil Porwal, Subrata Banik, Tarun Tuli.
Eran Mitrani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74885?usp=email )
Change subject: mb/google/rex/var/rex0: add HID over SPI ACPI driver ......................................................................
Patch Set 10:
(4 comments)
This change is ready for review.
Patchset:
PS2:
we should move this code into mainboard until we make it generic […]
Done
Patchset:
PS3:
Thanks, possible to rename to hid_spi_elan. […]
done
File src/drivers/spi/hid/elan/elan7b18uh.asl:
https://review.coreboot.org/c/coreboot/+/74885/comment/cb5d4e66_9c27dff8 : PS2, Line 48: \_SB.GPO0
\_SB.PCI0. […]
Done
File src/mainboard/google/rex/variants/rex0/include/variant/acpi/hid_spi_elan.asl:
https://review.coreboot.org/c/coreboot/+/74885/comment/1a861852_7a92a59f : PS8, Line 42: Interrupt(ResourceConsumer, Level, ActiveLow, Shared) : { : TOUCH_SCR_IRQ : }
Any particular reason to change it from `GpioInt` to regular `Interrupt`?
That's the one used for I2C, so using the same one