Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34411 )
Change subject: soc/intel: Expand SA_DEV_ROOT for ramstage
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34411/2/src/soc/intel/skylake/inclu...
File src/soc/intel/skylake/include/soc/pci_devs.h:
https://review.coreboot.org/c/coreboot/+/34411/2/src/soc/intel/skylake/inclu...
PS2, Line 35: SA_DEV_ROOT
Are these still being used anywhere? Can we get rid of it from . […]
Still used pre-ram, maybe smm.
I just realised we have smm-y += DEVICETREE_STATIC_C. How is that supposed to work? In ramstage, devicetree is mutable so smm only gets the outdated data.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34411
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I298f7f9a1c6a64cfba454e919eeaedc7bb2d4801
Gerrit-Change-Number: 34411
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Vanny E
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Comment-Date: Fri, 19 Jul 2019 04:53:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment