Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37760 )
Change subject: bootblock: Support normal/fallback mechanism again ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37760/5/src/arch/x86/Makefile.inc File src/arch/x86/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/37760/5/src/arch/x86/Makefile.inc@1... PS5, Line 115: bootblock-$(CONFIG_BOOTBLOCK_NORMAL) += bootblock_normal.c
What is the difference between 'normal' and 'simple'? It seems to me this new file should be named s […]
The simple one always boots fallback. This is how they were named with romcc bootblock too.
https://review.coreboot.org/c/coreboot/+/37760/5/src/arch/x86/bootblock_norm... File src/arch/x86/bootblock_normal.c:
https://review.coreboot.org/c/coreboot/+/37760/5/src/arch/x86/bootblock_norm... PS5, Line 33: boot_candidate = cbfs_boot_map_with_leak("coreboot-stages", CBFS_TYPE_RAW, &stages_len);
I wonder how much this was ever used. Should we keep this or only allow […]
I'd be willing to drop this.
https://review.coreboot.org/c/coreboot/+/37760/5/src/arch/x86/bootblock_norm... PS5, Line 37: if (do_normal_boot()) { This is where cmos flag comes into play.