Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35075 )
Change subject: drivers/i2c/generic: Support power resource as parent in device tree
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35075/2/src/drivers/i2c/generic/gen...
File src/drivers/i2c/generic/generic.c:
https://review.coreboot.org/c/coreboot/+/35075/2/src/drivers/i2c/generic/gen...
PS2, Line 68: * Because the power resource is a "pseudo-device", we don't want it
Why not? […]
I had issues getting the kernel to find the I2C device when the I2CSerialBus object had a path of _SB.PCI0.PR00.I2C0 for example. Maybe I did something else wrong, but I could not get the kernel to enumerate it unless it was _SB.PCI0.I2C0
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35075
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7554ab4fef88ffea0d3423ea27bb18a56b7f4de5
Gerrit-Change-Number: 35075
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Thu, 29 Aug 2019 17:01:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-MessageType: comment