Attention is currently required from: Tim Chu.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48640 )
Change subject: mb/ocp/deltalake: Override SMBIOS type 4 max speed
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
File src/mainboard/ocp/deltalake/ramstage.c:
https://review.coreboot.org/c/coreboot/+/48640/comment/7839c01a_a4226842
PS2, Line 99: smbios_cpu_get_max_speed_mhz
why is this mainboard specific? Shouldn't this part of the SoC as all boards selecting the SoC code support the same sockets/CPUs and thus the max speed is also the same?
https://review.coreboot.org/c/coreboot/+/48640/comment/80cef5af_2cef0ed0
PS2, Line 102: return 4000;
which datasheet is this value from?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48640
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I67edf657a2fe66b38e08056d558e1b360c4b8adc
Gerrit-Change-Number: 48640
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Ryback Hung
ryback.hung%quantatw.com@gtempaccount.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Wed, 03 Feb 2021 08:26:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment