Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48506 )
Change subject: soc/amd/picasso: use all-y for aoac target
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48506/3/src/soc/amd/picasso/Makefil...
File src/soc/amd/picasso/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/48506/3/src/soc/amd/picasso/Makefil...
PS3, Line 11:
At some point, let's eventually consider a comment here to caution against using all-y for files not […]
added that in a follow-up patch: CB:48521
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48506
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I74607123ebc8115aa7efbb9a364d9632372b52cb
Gerrit-Change-Number: 48506
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 10 Dec 2020 01:12:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-MessageType: comment