Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32297 )
Change subject: soc/intel/cannonlake: Enable PlatformDebugConsent by Kconfig ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/#/c/32297/5/src/soc/intel/cannonlake/Kconfig File src/soc/intel/cannonlake/Kconfig:
https://review.coreboot.org/#/c/32297/5/src/soc/intel/cannonlake/Kconfig@296 PS5, Line 296: control debug interface DCI? debug control interface?
https://review.coreboot.org/#/c/32297/5/src/soc/intel/cannonlake/Kconfig@298 PS5, Line 298: PlatformDebugConsent in FspmUpd.h has the details Please add a dot/period at the end.
https://review.coreboot.org/#/c/32297/5/src/soc/intel/cannonlake/Kconfig@296 PS5, Line 296: This is to control debug interface on SOC. : Setting non-zero value will allow to use DBC or DCI to debug SOC. : PlatformDebugConsent in FspmUpd.h has the details Please add a blank line between paragraphs or use the full text width.