Matt Papageorge has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42829 )
Change subject: soc/amd/picasso/sb: Gate FCH AL2AHB clocks
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42829/6/src/soc/amd/picasso/southbr...
File src/soc/amd/picasso/southbridge.c:
https://review.coreboot.org/c/coreboot/+/42829/6/src/soc/amd/picasso/southbr...
PS6, Line 340: AL2AHB_CONTROL_CLK_OFFSET
I suspect it is different (hence the change) but I have yet to hear back from the designers. […]
Heard back this AM. Those other clock gating bits are unrelated.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42829
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifcbc144a8769f8ea440cdd560bab146bf5058cf9
Gerrit-Change-Number: 42829
Gerrit-PatchSet: 6
Gerrit-Owner: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 23 Jul 2020 14:13:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-MessageType: comment