Nicola Corna (nicola@corna.info) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18310
-gerrit
commit 9a60116d749fa91ffce113b22fc1f3b5d572c16c Author: Nicola Corna nicola@corna.info Date: Tue Jan 24 12:42:36 2017 +0100
[RFC] Revert "drivers/pc80/tpm: Set default TPM acpi path if unset"
This reverts commit 3a1fbeaf6608d56b1fce2dfb88c76821b05849db.
Commit 3a1fbeaf6608d56b1fce2dfb88c76821b05849db introduced new bugs: * On X220 it breaks the brightness control: GNOME is now unable to control the brightness and the only way to control it is trough the physical buttons (but GNOME is unaware of this, as no popup appears). * On X201 it breaks the CPU governor: no governors are available in the sysfs.
Change-Id: I59de336af4cdfa5f6e8d56fa49025bc43a8264da Signed-off-by: Nicola Corna nicola@corna.info --- src/drivers/pc80/tpm/tpm.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/drivers/pc80/tpm/tpm.c b/src/drivers/pc80/tpm/tpm.c index 83dc923..57ea919 100644 --- a/src/drivers/pc80/tpm/tpm.c +++ b/src/drivers/pc80/tpm/tpm.c @@ -875,10 +875,8 @@ static void lpc_tpm_fill_ssdt(struct device *dev) struct opregion opreg = OPREGION("TREG", SYSTEMMEMORY, CONFIG_TPM_TIS_BASE_ADDRESS, 0x5000);
- if (!path) { - path = "PCI0.LPCB"; - printk(BIOS_DEBUG, "Using default TPM ACPI path: '%s'\n", path); - } + if (!path) + return;
/* Device */ acpigen_write_scope(path);