Attention is currently required from: Shelley Chen, Taniya Das, Venkat Thogaru, Julius Werner, Sudheer Amrabadi.
Taniya Das has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68384 )
Change subject: soc/qualcomm/sc7280: Add socinfo_pro_part() function in coreboot
......................................................................
Patch Set 8:
(3 comments)
File src/soc/qualcomm/sc7280/include/soc/socinfo.h:
https://review.coreboot.org/c/coreboot/+/68384/comment/fd98a3a9_a2760464
PS6, Line 53: uint16_t jtagid;
This could still be […]
Done
File src/soc/qualcomm/sc7280/socinfo.c:
https://review.coreboot.org/c/coreboot/+/68384/comment/afc861e3_86053dc5
PS4, Line 12: static struct chipinfo chipinfolut[] = {
Can you clarify what future purpose? Where are we going to need these?
This is to keep it more aligned to our internal code and easy code readability.
File src/soc/qualcomm/sc7280/socinfo.c:
https://review.coreboot.org/c/coreboot/+/68384/comment/56f7bf62_2ad7aac5
PS6, Line 53: for (i = 0; i < ARRAY_SIZE(chipinfolut); i++)
The lookup part for both of these could be factored out into a helper function.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68384
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id9f23696384a6c1a89000292eafebd8a16c273ca
Gerrit-Change-Number: 68384
Gerrit-PatchSet: 8
Gerrit-Owner: Sudheer Amrabadi
samrabad@codeaurora.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Taniya Das
quic_tdas@quicinc.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Taniya Das
tdas@qualcomm.corp-partner.google.com
Gerrit-CC: Venkat Thogaru
thogaru@qualcomm.corp-partner.google.com
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Taniya Das
quic_tdas@quicinc.com
Gerrit-Attention: Venkat Thogaru
thogaru@qualcomm.corp-partner.google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Sudheer Amrabadi
samrabad@codeaurora.org
Gerrit-Comment-Date: Tue, 01 Nov 2022 09:55:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Taniya Das
tdas@qualcomm.corp-partner.google.com
Gerrit-MessageType: comment