build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34545 )
Change subject: SPM: mt8183: support spm suspend in coreboot
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34545/2/src/soc/mediatek/mt8183/spm...
File src/soc/mediatek/mt8183/spm.c:
https://review.coreboot.org/c/coreboot/+/34545/2/src/soc/mediatek/mt8183/spm...
PS2, Line 208: static const char * dyna_load_pcm_path[] = {
static const char * array should probably be static const char * const
https://review.coreboot.org/c/coreboot/+/34545/2/src/soc/mediatek/mt8183/spm...
PS2, Line 208: static const char * dyna_load_pcm_path[] = {
"foo * bar" should be "foo *bar"
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34545
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3393a772f025b0912a5a25a63a87512454fbc86e
Gerrit-Change-Number: 34545
Gerrit-PatchSet: 2
Gerrit-Owner: DAWEI CHIEN
dawei.chien@mediatek.com
Gerrit-Reviewer: DAWEI CHIEN
dawei.chien@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: SJ Huang
sj.huang@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Wed, 24 Jul 2019 11:52:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment