Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48117 )
Change subject: mb/intel/ehlcrb: Remove ChromeOS support from mainboard ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/48117/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48117/3//COMMIT_MSG@9 PS3, Line 9: for EHL
I guess it will be more clear if you write here "for EHL CRB" as there is nothing to prevent chrome […]
Done
https://review.coreboot.org/c/coreboot/+/48117/3//COMMIT_MSG@12 PS3, Line 12: kconfigs
Kconfig switches?
Done
https://review.coreboot.org/c/coreboot/+/48117/3//COMMIT_MSG@14 PS3, Line 14: & chromeos.c codes from makefile.c
You can drop this as removing chromeos.c intents that you remove it from Makefile.inc as well.
Done
https://review.coreboot.org/c/coreboot/+/48117/3//COMMIT_MSG@14 PS3, Line 14: makefile.c
Makefile. […]
Done