Michael Büchler has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45184 )
Change subject: cpu/intel/model_1067x: enable PECI ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45184/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45184/1//COMMIT_MSG@13 PS1, Line 13: erratum AW67 "Enabling PECI via the PECI_CTL : MSR incorrectly writes CPUID_FEATURE_MASK1 MSR". The suggested : workaround is "Do not initialize PECI before processor update is : loaded". Since coreboot performs microcode updates before running this : code it should not cause any trouble.
Maybe add this as a comment in the code to make sure that (although unlikely) future development kee […]
Sounds like a good idea. I rephrased it a bit - what do you think?