Attention is currently required from: David Ruth, Eric Lai, Kapil Porwal, Nick Vaccaro.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80305?usp=email )
Change subject: mb/google/nissa/var/yaviks: Enable USE_MTCL for YAVIKS ......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/80305/comment/ec54e994_1067c9b3 : PS1, Line 489: select USE_MTCL
Nothing declares DRIVERS_INTEL_WIFI, but almost all of these boards have variants with Intel WiFi chips. I tried to figure out why that was, and I found the following:
PCIEXP_PLUGIN_SUPPORT is enabled by default (see /src/third_party/coreboot/src/device/Kconfig), so DRIVERS_MTK_WIFI and DRIVERS_INTEL_WIFI are both effectively enabled by default.
This isn't technically necessary (I've tested it multiple times at this point), and it seems to go against convention. My inclination (unless there's a strong preference otherwise) is to not add this.
if it's default enabled then we are good bt ideally it's better u select the required Kconfig as per BoM choice directly.