[coreboot-gerrit] Change in ...coreboot[master]: mb/google/hatch: Configure miscellaneous features

[Rizwan Qureshi (Code Review)]

Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30774 )

Change subject: mb/google/hatch: Configure miscellaneous features
......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/#/c/30774/6/src/mainboard/google/hatch/variants/... 
File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:

https://review.coreboot.org/#/c/30774/6/src/mainboard/google/hatch/variants/... 
PS6, Line 56: VmxEnable
> I will get back to you with more information.

I think this was clarified earlier, if FSP skips the MP init (which is the case for Hatch) this setting has no effect. we should be removing this and using the VMX configuration being done in coreboot MP init. i.e., select SOC_INTEL_COMMON_BLOCK_VMX and call vmx_configure() on all cpus.