Attention is currently required from: Cliff Huang, David Ruth, Lance Zhao, Paul Menzel, Subrata Banik, Subrata Banik, Tim Wawrzynczak.
Hello Cliff Huang, Lance Zhao, Subrata Banik, Tim Wawrzynczak, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80170?usp=email
to look at the new patch set (#8).
The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins)
Change subject: Add MTCL function to ACPI SSDT tables ......................................................................
Add MTCL function to ACPI SSDT tables
The MTCL function provides a country list to the Linux kernel via an ACPI function in SSDT for MediaTek WiFi chipsets that are capable of operating on the 6GHz band. The country list is used to selectively disable 6GHz and 5.9GHz operation based on the country the device is operating in.
The function needs to read a binary file and send it as a package via the MTCL method in SSDT for PCIe WiFi with MediaTek chipsets.
Change Summary: * Adds acpigen_write_mtcl in order to generate the AML code for the MTCL method. * Adds the mtcl.c file to abstract functionality related to reading the binary file that defines the MTCL, and verifying that the format is one intended to be handled by this implementation. * Reads a binary file called "wifi_mtcl.hex" in cbfs * Verifies that the format matches a supported value * Returns the size and byte array to caller * Adds config flag DRIVERS_MTK_WIFI to src/drivers/wifi/generic in order to include MediaTek WiFi specific functionality * Adds config flag USE_MTCL which depends on DRIVERS_MTK_WIFI and enables including the specific ACPI function defined in SSDT * Adds config flag CONFIG_WIFI_MTCL_CBFS_FILEPATH which depends on DRIVERS_MTK_WIFI which enables configuring the file to add as "wifi_mtcl.hex" * Adds functionality to src/drivers/wifi/generic/acpi.c to include the MTCL function in SSDT for WiFi devices when the above flags are enabled
BUG=b:295544553 TEST=Add Kconfig entry USE_MTCL for pujjo TEST=Add wifi_mtcl_defaults.hex blob to cbfs TEST=Build coreboot for pujjo `emerge-nissa coreboot chromeos-bootimage` TEST=Verify that MTCL defined in the file is present: TEST=`acpidump -b` TEST=`iasl ssdt.dat` TEST=`less ssdt.dsl` TEST=Search for MTCL
Signed-off-by: David Ruth druth@chromium.org Change-Id: I9b5e7312a44e114270e664b983626faa6cfee350 --- M src/acpi/acpigen.c M src/drivers/wifi/generic/Kconfig M src/drivers/wifi/generic/Makefile.inc M src/drivers/wifi/generic/acpi.c A src/drivers/wifi/generic/mtcl.c M src/include/acpi/acpigen.h M src/include/device/pci_ids.h A src/include/mtcl.h 8 files changed, 219 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/80170/8