[coreboot-gerrit] Change in coreboot[master]: cpu/x86/cache: CLFLUSH programs to memory before running

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37196 )

Change subject: cpu/x86/cache: CLFLUSH programs to memory before running
......................................................................

Patch Set 13:

(2 comments)

https://review.coreboot.org/c/coreboot/+/37196/12/src/cpu/x86/cache/cache.c 
File src/cpu/x86/cache/cache.c:

https://review.coreboot.org/c/coreboot/+/37196/12/src/cpu/x86/cache/cache.c@... 
PS12, Line 21: ENV_POSTCAR || ENV_RAMSTAGE
> Isn't there a symbol for pre-RAM stages?

`!ENV_CACHE_AS_RAM` might be a good choice, it also covers the
`RESET_VECTOR_IN_RAM` case.

https://review.coreboot.org/c/coreboot/+/37196/12/src/cpu/x86/cache/cache.c@... 
PS12, Line 24: CONFIG(X86_CLFLUSH_CAR)
> Why not place the constant on the left-hand side of the operation?

I'm curious, does the compiler optimize it differently?

As the the operand has no side effects, it should be safe to treat it
the same.