View Change

2 comments:

• File src/cpu/x86/cache/cache.c:

  • Patch Set #12, Line 21: ENV_POSTCAR || ENV_RAMSTAGE

    Isn't there a symbol for pre-RAM stages?

    `!ENV_CACHE_AS_RAM` might be a good choice, it also covers the
    `RESET_VECTOR_IN_RAM` case.

  • Patch Set #12, Line 24: CONFIG(X86_CLFLUSH_CAR)

    Why not place the constant on the left-hand side of the operation?

    I'm curious, does the compiler optimize it differently?

    As the the operand has no side effects, it should be safe to treat it
    the same.

To view, visit change 37196. To unsubscribe, or for help writing mail filters, visit settings.