Ana Carolina Cabral has posted comments on this change by Ana Carolina Cabral. ( https://review.coreboot.org/c/coreboot/+/86084?usp=email )
Change subject: mb/amd/birman_plus/ec: Rectify ECRAM register bits
......................................................................
Patch Set 14:
(1 comment)
File src/mainboard/amd/birman_plus/ec.c:
https://review.coreboot.org/c/coreboot/+/86084/comment/097a1463_da8bdb7b?usp... :
PS13, Line 33: #define EC_GPIO_7_ADDR 0xA7
do we also need to bring BIT(6) of this one into a defined state?
PI doesn't use A7[6] anywhere..
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86084?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1a13d99a55a4aa02a5cb0e67ffa4ed555f91a471
Gerrit-Change-Number: 86084
Gerrit-PatchSet: 14
Gerrit-Owner: Ana Carolina Cabral
ana.cpmelo95@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Sun, 02 Feb 2025 22:02:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de