Attention is currently required from: Bora Guvendik, Maulik V Vaghela, Selma Bensaid, Rizwan Qureshi.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52865 )
Change subject: mb/intel/adlrvp_m: Program CPU PCIE RP GPIOs in early GPIO
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS2:
This change looks okay. But long term, I think it should be evaluated if there are ways to delay this programming until ramstage.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52865
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I27c898943471d834bd82e3c7e8b36cceb12de099
Gerrit-Change-Number: 52865
Gerrit-PatchSet: 2
Gerrit-Owner: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Comment-Date: Tue, 11 May 2021 02:18:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment