build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47290 )
Change subject: mb/intel/adlrvp: Configure the HPD GPIO's ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/c/coreboot/+/47290/1/src/mainboard/intel/adlrvp/... File src/mainboard/intel/adlrvp/variants/adlrvp_p/gpio.c:
https://review.coreboot.org/c/coreboot/+/47290/1/src/mainboard/intel/adlrvp/... PS1, Line 280: /* HPD_1 (A19) and HPD_2 (A20) pins */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/47290/1/src/mainboard/intel/adlrvp/... PS1, Line 281: PAD_CFG_NF(GPP_A19, NONE, DEEP, NF1), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/47290/1/src/mainboard/intel/adlrvp/... PS1, Line 281: PAD_CFG_NF(GPP_A19, NONE, DEEP, NF1), please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/47290/1/src/mainboard/intel/adlrvp/... PS1, Line 282: PAD_CFG_NF(GPP_A20, NONE, DEEP, NF1), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/47290/1/src/mainboard/intel/adlrvp/... PS1, Line 282: PAD_CFG_NF(GPP_A20, NONE, DEEP, NF1), please, no spaces at the start of a line