build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33234 )
Change subject: security/intel/stm STM support ......................................................................
Patch Set 1:
(1387 comments)
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.h File src/security/intel/stm/SmmStm.h:
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.h@7 PS1, Line 7: accompanies this distribution. The full text of the license may trailing whitespace
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.h@37 PS1, Line 37: void *StmImage, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.h@38 PS1, Line 38: uint32_t StmImageSize please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.h@39 PS1, Line 39: ); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.h@47 PS1, Line 47: If 0, list must be terminated by END_OF_RESOURCES. code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.h@51 PS1, Line 51: @retval OUT_OF_RESOURCES If nested procedure returned it and we cannot allocate more areas. line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.h@55 PS1, Line 55: STM_RSC *ResourceList, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.h@56 PS1, Line 56: uint32_t NumEntries please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.h@57 PS1, Line 57: ); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.h@64 PS1, Line 64: NULL means delete all resources. code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.h@66 PS1, Line 66: If 0, list must be terminated by END_OF_RESOURCES. code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.h@73 PS1, Line 73: STM_RSC *ResourceList, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.h@74 PS1, Line 74: uint32_t NumEntries please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.h@75 PS1, Line 75: ); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.h@83 PS1, Line 83: On output it means size of resource list filled, code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.h@84 PS1, Line 84: or the size of resource list to be filled if trailing whitespace
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.h@84 PS1, Line 84: or the size of resource list to be filled if code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.h@88 PS1, Line 88: @retval BUFFER_TOO_SMALL If resource list buffer is too small to trailing whitespace
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.h@93 PS1, Line 93: STM_RSC *ResourceList, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.h@94 PS1, Line 94: uint32_t *ResourceSize please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.h@95 PS1, Line 95: ); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.h@105 PS1, Line 105: void *StmResource please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.h@106 PS1, Line 106: ); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.h@114 PS1, Line 114: void * function definition argument 'void' should also have an identifier name
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.h@116 PS1, Line 116: void please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.h@117 PS1, Line 117: ); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c File src/security/intel/stm/SmmStm.c:
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@39 PS1, Line 39: #define STM_SIZE_TO_PAGES(a) (((a) >> STM_PAGE_SHIFT) + (((a) & STM_PAGE_MASK) ? 1 : 0)) line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@54 PS1, Line 54: bool StmCheckStmImage(void * StmImage, uint32_t StmImageSize); "foo * bar" should be "foo *bar"
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@55 PS1, Line 55: void StmLoadStmImage(void * StmImage, UINTN StmImageSize); "foo * bar" should be "foo *bar"
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@140 PS1, Line 140: ) please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@148 PS1, Line 148: ResourceHi = 0; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@148 PS1, Line 148: ResourceHi = 0; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@148 PS1, Line 148: ResourceHi = 0; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@149 PS1, Line 149: RecordLo = 0; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@149 PS1, Line 149: RecordLo = 0; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@149 PS1, Line 149: RecordLo = 0; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@150 PS1, Line 150: RecordHi = 0; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@150 PS1, Line 150: RecordHi = 0; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@150 PS1, Line 150: RecordHi = 0; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@158 PS1, Line 158: switch (Resource->Header.RscType) { switch and case should be at the same indent
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@165 PS1, Line 165: if (Resource->Mem.RWXAttributes != Record->Mem.RWXAttributes) { line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@166 PS1, Line 166: if ((ResourceLo == RecordLo) && (ResourceHi == RecordHi)) { line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@166 PS1, Line 166: if ((ResourceLo == RecordLo) && (ResourceHi == RecordHi)) { code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@166 PS1, Line 166: if ((ResourceLo == RecordLo) && (ResourceHi == RecordHi)) { please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@166 PS1, Line 166: if ((ResourceLo == RecordLo) && (ResourceHi == RecordHi)) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@167 PS1, Line 167: Record->Mem.RWXAttributes = Resource->Mem.RWXAttributes | Record->Mem.RWXAttributes; line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@167 PS1, Line 167: Record->Mem.RWXAttributes = Resource->Mem.RWXAttributes | Record->Mem.RWXAttributes; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@167 PS1, Line 167: Record->Mem.RWXAttributes = Resource->Mem.RWXAttributes | Record->Mem.RWXAttributes; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@167 PS1, Line 167: Record->Mem.RWXAttributes = Resource->Mem.RWXAttributes | Record->Mem.RWXAttributes; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@168 PS1, Line 168: return true; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@168 PS1, Line 168: return true; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@168 PS1, Line 168: return true; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@169 PS1, Line 169: } else { code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@169 PS1, Line 169: } else { please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@169 PS1, Line 169: } else { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@170 PS1, Line 170: return false; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@170 PS1, Line 170: return false; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@170 PS1, Line 170: return false; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@171 PS1, Line 171: } code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@171 PS1, Line 171: } please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@171 PS1, Line 171: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@172 PS1, Line 172: } code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@172 PS1, Line 172: } please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@172 PS1, Line 172: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@173 PS1, Line 173: break; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@173 PS1, Line 173: break; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@173 PS1, Line 173: break; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@177 PS1, Line 177: ResourceHi = (uint64_t) Resource->Io.Base + (uint64_t) Resource->Io.Length; line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@177 PS1, Line 177: ResourceHi = (uint64_t) Resource->Io.Base + (uint64_t) Resource->Io.Length; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@177 PS1, Line 177: ResourceHi = (uint64_t) Resource->Io.Base + (uint64_t) Resource->Io.Length; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@177 PS1, Line 177: ResourceHi = (uint64_t) Resource->Io.Base + (uint64_t) Resource->Io.Length; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@179 PS1, Line 179: RecordHi = (uint64_t) Record->Io.Base + (uint64_t) Record->Io.Length; line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@179 PS1, Line 179: RecordHi = (uint64_t) Record->Io.Base + (uint64_t) Record->Io.Length; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@179 PS1, Line 179: RecordHi = (uint64_t) Record->Io.Base + (uint64_t) Record->Io.Length; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@179 PS1, Line 179: RecordHi = (uint64_t) Record->Io.Base + (uint64_t) Record->Io.Length; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@182 PS1, Line 182: if ((Resource->PciCfg.OriginatingBusNumber != Record->PciCfg.OriginatingBusNumber) || line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@183 PS1, Line 183: (Resource->PciCfg.LastNodeIndex != Record->PciCfg.LastNodeIndex)) { line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@185 PS1, Line 185: } trailing whitespace
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@186 PS1, Line 186: if (memcmp (Resource->PciCfg.PciDevicePath, Record->PciCfg.PciDevicePath, sizeof(STM_PCI_DEVICE_PATH_NODE) * (Resource->PciCfg.LastNodeIndex + 1)) != 0) { line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@186 PS1, Line 186: if (memcmp (Resource->PciCfg.PciDevicePath, Record->PciCfg.PciDevicePath, sizeof(STM_PCI_DEVICE_PATH_NODE) * (Resource->PciCfg.LastNodeIndex + 1)) != 0) { code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@186 PS1, Line 186: if (memcmp (Resource->PciCfg.PciDevicePath, Record->PciCfg.PciDevicePath, sizeof(STM_PCI_DEVICE_PATH_NODE) * (Resource->PciCfg.LastNodeIndex + 1)) != 0) { please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@186 PS1, Line 186: if (memcmp (Resource->PciCfg.PciDevicePath, Record->PciCfg.PciDevicePath, sizeof(STM_PCI_DEVICE_PATH_NODE) * (Resource->PciCfg.LastNodeIndex + 1)) != 0) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@186 PS1, Line 186: if (memcmp (Resource->PciCfg.PciDevicePath, Record->PciCfg.PciDevicePath, sizeof(STM_PCI_DEVICE_PATH_NODE) * (Resource->PciCfg.LastNodeIndex + 1)) != 0) { space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@186 PS1, Line 186: if (memcmp (Resource->PciCfg.PciDevicePath, Record->PciCfg.PciDevicePath, sizeof(STM_PCI_DEVICE_PATH_NODE) * (Resource->PciCfg.LastNodeIndex + 1)) != 0) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@188 PS1, Line 188: } code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@188 PS1, Line 188: } please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@188 PS1, Line 188: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@190 PS1, Line 190: ResourceHi = (uint64_t) Resource->PciCfg.Base + (uint64_t) Resource->PciCfg.Length; line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@192 PS1, Line 192: RecordHi = (uint64_t) Record->PciCfg.Base + (uint64_t) Record->PciCfg.Length; line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@193 PS1, Line 193: if (Resource->PciCfg.RWAttributes != Record->PciCfg.RWAttributes) { line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@194 PS1, Line 194: if ((ResourceLo == RecordLo) && (ResourceHi == RecordHi)) { line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@195 PS1, Line 195: Record->PciCfg.RWAttributes = Resource->PciCfg.RWAttributes | Record->PciCfg.RWAttributes; line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@200 PS1, Line 200: } code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@200 PS1, Line 200: } please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@200 PS1, Line 200: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@201 PS1, Line 201: break; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@201 PS1, Line 201: break; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@201 PS1, Line 201: break; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@203 PS1, Line 203: // code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@203 PS1, Line 203: // please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@203 PS1, Line 203: // please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@204 PS1, Line 204: // Special case - merge MSR masks in place. code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@204 PS1, Line 204: // Special case - merge MSR masks in place. please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@204 PS1, Line 204: // Special case - merge MSR masks in place. please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@205 PS1, Line 205: // code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@205 PS1, Line 205: // please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@205 PS1, Line 205: // please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@206 PS1, Line 206: if (Resource->Msr.MsrIndex != Record->Msr.MsrIndex) { code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@206 PS1, Line 206: if (Resource->Msr.MsrIndex != Record->Msr.MsrIndex) { please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@206 PS1, Line 206: if (Resource->Msr.MsrIndex != Record->Msr.MsrIndex) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@206 PS1, Line 206: if (Resource->Msr.MsrIndex != Record->Msr.MsrIndex) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@208 PS1, Line 208: } code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@208 PS1, Line 208: } please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@208 PS1, Line 208: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@209 PS1, Line 209: Record->Msr.ReadMask |= Resource->Msr.ReadMask; trailing whitespace
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@209 PS1, Line 209: Record->Msr.ReadMask |= Resource->Msr.ReadMask; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@209 PS1, Line 209: Record->Msr.ReadMask |= Resource->Msr.ReadMask; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@209 PS1, Line 209: Record->Msr.ReadMask |= Resource->Msr.ReadMask; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@210 PS1, Line 210: Record->Msr.WriteMask |= Resource->Msr.WriteMask; trailing whitespace
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@211 PS1, Line 211: return true; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@211 PS1, Line 211: return true; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@211 PS1, Line 211: return true; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@213 PS1, Line 213: return false; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@213 PS1, Line 213: return false; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@213 PS1, Line 213: return false; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@218 PS1, Line 218: if ((ResourceHi < RecordLo) || (ResourceLo > RecordHi)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@219 PS1, Line 219: return false; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@219 PS1, Line 219: return false; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@219 PS1, Line 219: return false; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@224 PS1, Line 224: // trailing whitespace
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@225 PS1, Line 225: if ((ResourceLo >= RecordLo) && (ResourceHi <= RecordHi)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@226 PS1, Line 226: return true; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@226 PS1, Line 226: return true; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@226 PS1, Line 226: return true; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@227 PS1, Line 227: } code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@227 PS1, Line 227: } please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@227 PS1, Line 227: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@229 PS1, Line 229: // Resources are overlapping. code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@229 PS1, Line 229: // Resources are overlapping. please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@229 PS1, Line 229: // Resources are overlapping. please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@230 PS1, Line 230: // Resource and record are merged. code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@230 PS1, Line 230: // Resource and record are merged. please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@230 PS1, Line 230: // Resource and record are merged. please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@231 PS1, Line 231: // code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@231 PS1, Line 231: // please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@231 PS1, Line 231: // please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@232 PS1, Line 232: ResourceLo = (ResourceLo < RecordLo) ? ResourceLo : RecordLo; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@232 PS1, Line 232: ResourceLo = (ResourceLo < RecordLo) ? ResourceLo : RecordLo; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@232 PS1, Line 232: ResourceLo = (ResourceLo < RecordLo) ? ResourceLo : RecordLo; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@235 PS1, Line 235: switch (Resource->Header.RscType) { code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@235 PS1, Line 235: switch (Resource->Header.RscType) { please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@235 PS1, Line 235: switch (Resource->Header.RscType) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@235 PS1, Line 235: switch (Resource->Header.RscType) { switch and case should be at the same indent
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@240 PS1, Line 240: break; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@240 PS1, Line 240: break; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@240 PS1, Line 240: break; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@243 PS1, Line 243: Record->Io.Base = (uint64_t) ResourceLo; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@243 PS1, Line 243: Record->Io.Base = (uint64_t) ResourceLo; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@243 PS1, Line 243: Record->Io.Base = (uint64_t) ResourceLo; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@244 PS1, Line 244: Record->Io.Length = (uint64_t) (ResourceHi - ResourceLo); line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@244 PS1, Line 244: Record->Io.Length = (uint64_t) (ResourceHi - ResourceLo); code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@244 PS1, Line 244: Record->Io.Length = (uint64_t) (ResourceHi - ResourceLo); please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@244 PS1, Line 244: Record->Io.Length = (uint64_t) (ResourceHi - ResourceLo); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@245 PS1, Line 245: break; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@245 PS1, Line 245: break; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@245 PS1, Line 245: break; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@248 PS1, Line 248: Record->PciCfg.Length = (uint64_t) (ResourceHi - ResourceLo); line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@249 PS1, Line 249: break; trailing whitespace
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@251 PS1, Line 251: return false; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@251 PS1, Line 251: return false; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@251 PS1, Line 251: return false; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@271 PS1, Line 271: if (Record->Header.RscType == END_OF_RESOURCES) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@278 PS1, Line 278: Record = (STM_RSC *)((void *)Record + Record->Header.Length); line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@279 PS1, Line 279: continue; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@279 PS1, Line 279: continue; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@279 PS1, Line 279: continue; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@284 PS1, Line 284: if (HandleSingleResource (Resource, Record)) { space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@284 PS1, Line 284: if (HandleSingleResource (Resource, Record)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@285 PS1, Line 285: return ; space prohibited before semicolon
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@286 PS1, Line 286: } trailing whitespace
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@286 PS1, Line 286: } code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@286 PS1, Line 286: } please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@286 PS1, Line 286: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@293 PS1, Line 293: memcpy ( space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@297 PS1, Line 297: ); code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@297 PS1, Line 297: ); please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@297 PS1, Line 297: ); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@298 PS1, Line 298: memcpy ( space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@299 PS1, Line 299: mStmResourcesPtr + mStmResourceSizeUsed - sizeof(mRscEndNode) + Resource->Header.Length, line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@299 PS1, Line 299: mStmResourcesPtr + mStmResourceSizeUsed - sizeof(mRscEndNode) + Resource->Header.Length, code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@299 PS1, Line 299: mStmResourcesPtr + mStmResourceSizeUsed - sizeof(mRscEndNode) + Resource->Header.Length, please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@299 PS1, Line 299: mStmResourcesPtr + mStmResourceSizeUsed - sizeof(mRscEndNode) + Resource->Header.Length, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@300 PS1, Line 300: &mRscEndNode, code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@300 PS1, Line 300: &mRscEndNode, please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@300 PS1, Line 300: &mRscEndNode, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@302 PS1, Line 302: ); code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@302 PS1, Line 302: ); please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@302 PS1, Line 302: ); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@304 PS1, Line 304: mStmResourceSizeAvailable = mStmResourceTotalSize - mStmResourceSizeUsed; line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@306 PS1, Line 306: return ; space prohibited before semicolon
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@307 PS1, Line 307: } void function return statements are not generally useful
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@324 PS1, Line 324: if (NumEntries == 0) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@331 PS1, Line 331: trailing whitespace
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@331 PS1, Line 331: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@333 PS1, Line 333: if (Resource->Header.RscType == END_OF_RESOURCES) { code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@333 PS1, Line 333: if (Resource->Header.RscType == END_OF_RESOURCES) { please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@333 PS1, Line 333: if (Resource->Header.RscType == END_OF_RESOURCES) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@333 PS1, Line 333: if (Resource->Header.RscType == END_OF_RESOURCES) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@334 PS1, Line 334: return ; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@334 PS1, Line 334: return ; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@334 PS1, Line 334: return ; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@334 PS1, Line 334: return ; space prohibited before semicolon
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@336 PS1, Line 336: AddSingleResource (Resource); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@337 PS1, Line 337: Resource = (STM_RSC *)((void *)Resource + Resource->Header.Length); line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@339 PS1, Line 339: return ; space prohibited before semicolon
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@340 PS1, Line 340: } void function return statements are not generally useful
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@348 PS1, Line 348: If 0, list must be terminated by END_OF_RESOURCES. code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@355 PS1, Line 355: ValidateResource ( space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@356 PS1, Line 356: STM_RSC *ResourceList, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@357 PS1, Line 357: uint32_t NumEntries please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@358 PS1, Line 358: ) please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@360 PS1, Line 360: uint32_t Count; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@361 PS1, Line 361: UINTN Index; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@362 PS1, Line 362: STM_RSC *Resource; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@363 PS1, Line 363: UINTN SubIndex; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@367 PS1, Line 367: // END_OF_RESOURCES. trailing whitespace
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@368 PS1, Line 368: // trailing whitespace
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@369 PS1, Line 369: if (NumEntries == 0) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@369 PS1, Line 369: if (NumEntries == 0) { suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@369 PS1, Line 369: if (NumEntries == 0) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@370 PS1, Line 370: Count = 0xFFFFFFFF; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@371 PS1, Line 371: } else { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@371 PS1, Line 371: } else { suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@372 PS1, Line 372: Count = NumEntries; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@373 PS1, Line 373: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@377 PS1, Line 377: // trailing whitespace
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@378 PS1, Line 378: Resource = ResourceList; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@379 PS1, Line 379: trailing whitespace
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@379 PS1, Line 379: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@380 PS1, Line 380: for (Index = 0; Index < Count; Index++) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@380 PS1, Line 380: for (Index = 0; Index < Count; Index++) { suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@381 PS1, Line 381: printk(BIOS_DEBUG, "ValidateResource (%llu) - RscType(%x)\n", Index, Resource->Header.RscType); line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@381 PS1, Line 381: printk(BIOS_DEBUG, "ValidateResource (%llu) - RscType(%x)\n", Index, Resource->Header.RscType); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@381 PS1, Line 381: printk(BIOS_DEBUG, "ValidateResource (%llu) - RscType(%x)\n", Index, Resource->Header.RscType); Prefer using '"%s...", __func__' to using 'ValidateResource', this function's name, in a string
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@383 PS1, Line 383: // Validate resource. trailing whitespace
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@384 PS1, Line 384: // trailing whitespace
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@385 PS1, Line 385: switch (Resource->Header.RscType) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@385 PS1, Line 385: switch (Resource->Header.RscType) { switch and case should be at the same indent
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@386 PS1, Line 386: case END_OF_RESOURCES: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@387 PS1, Line 387: if (Resource->Header.Length != sizeof (STM_RSC_END)) { code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@387 PS1, Line 387: if (Resource->Header.Length != sizeof (STM_RSC_END)) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@387 PS1, Line 387: if (Resource->Header.Length != sizeof (STM_RSC_END)) { suspect code indent for conditional statements (8, 10)
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@387 PS1, Line 387: if (Resource->Header.Length != sizeof (STM_RSC_END)) { space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@387 PS1, Line 387: if (Resource->Header.Length != sizeof (STM_RSC_END)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@388 PS1, Line 388: return false; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@388 PS1, Line 388: return false; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@389 PS1, Line 389: } code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@389 PS1, Line 389: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@390 PS1, Line 390: // code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@391 PS1, Line 391: // If we are passed actual number of resources to add, code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@392 PS1, Line 392: // END_OF_RESOURCES structure between them is considered an code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@393 PS1, Line 393: // error. If NumEntries == 0 END_OF_RESOURCES is a termination. trailing whitespace
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@393 PS1, Line 393: // error. If NumEntries == 0 END_OF_RESOURCES is a termination. code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@394 PS1, Line 394: // code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@395 PS1, Line 395: if (NumEntries != 0) { code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@395 PS1, Line 395: if (NumEntries != 0) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@395 PS1, Line 395: if (NumEntries != 0) { suspect code indent for conditional statements (8, 10)
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@396 PS1, Line 396: return false; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@396 PS1, Line 396: return false; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@397 PS1, Line 397: } else { code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@397 PS1, Line 397: } else { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@397 PS1, Line 397: } else { suspect code indent for conditional statements (8, 10)
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@398 PS1, Line 398: // code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@399 PS1, Line 399: // If NumEntries == 0 and list reached end - return success. code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@400 PS1, Line 400: // trailing whitespace
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@400 PS1, Line 400: // code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@401 PS1, Line 401: return true; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@401 PS1, Line 401: return true; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@402 PS1, Line 402: } code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@402 PS1, Line 402: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@403 PS1, Line 403: break; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@403 PS1, Line 403: break; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@405 PS1, Line 405: case MEM_RANGE: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@406 PS1, Line 406: case MMIO_RANGE: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@407 PS1, Line 407: if (Resource->Header.Length != sizeof (STM_RSC_MEM_DESC)) { code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@407 PS1, Line 407: if (Resource->Header.Length != sizeof (STM_RSC_MEM_DESC)) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@407 PS1, Line 407: if (Resource->Header.Length != sizeof (STM_RSC_MEM_DESC)) { suspect code indent for conditional statements (8, 10)
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@407 PS1, Line 407: if (Resource->Header.Length != sizeof (STM_RSC_MEM_DESC)) { space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@407 PS1, Line 407: if (Resource->Header.Length != sizeof (STM_RSC_MEM_DESC)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@408 PS1, Line 408: return false; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@408 PS1, Line 408: return false; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@409 PS1, Line 409: } code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@409 PS1, Line 409: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@411 PS1, Line 411: if (Resource->Mem.RWXAttributes > FULL_ACCS) { code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@411 PS1, Line 411: if (Resource->Mem.RWXAttributes > FULL_ACCS) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@411 PS1, Line 411: if (Resource->Mem.RWXAttributes > FULL_ACCS) { suspect code indent for conditional statements (8, 10)
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@411 PS1, Line 411: if (Resource->Mem.RWXAttributes > FULL_ACCS) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@412 PS1, Line 412: return false; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@412 PS1, Line 412: return false; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@413 PS1, Line 413: } code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@413 PS1, Line 413: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@414 PS1, Line 414: break; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@414 PS1, Line 414: break; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@415 PS1, Line 415: trailing whitespace
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@415 PS1, Line 415: code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@415 PS1, Line 415: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@416 PS1, Line 416: case IO_RANGE: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@417 PS1, Line 417: case TRAPPED_IO_RANGE: trailing whitespace
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@417 PS1, Line 417: case TRAPPED_IO_RANGE: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@418 PS1, Line 418: if (Resource->Header.Length != sizeof (STM_RSC_IO_DESC)) { code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@418 PS1, Line 418: if (Resource->Header.Length != sizeof (STM_RSC_IO_DESC)) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@418 PS1, Line 418: if (Resource->Header.Length != sizeof (STM_RSC_IO_DESC)) { suspect code indent for conditional statements (8, 10)
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@418 PS1, Line 418: if (Resource->Header.Length != sizeof (STM_RSC_IO_DESC)) { space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@418 PS1, Line 418: if (Resource->Header.Length != sizeof (STM_RSC_IO_DESC)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@419 PS1, Line 419: return false; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@419 PS1, Line 419: return false; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@420 PS1, Line 420: } code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@420 PS1, Line 420: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@422 PS1, Line 422: if ((Resource->Io.Base + Resource->Io.Length) > 0xFFFF) { code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@422 PS1, Line 422: if ((Resource->Io.Base + Resource->Io.Length) > 0xFFFF) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@422 PS1, Line 422: if ((Resource->Io.Base + Resource->Io.Length) > 0xFFFF) { suspect code indent for conditional statements (8, 10)
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@422 PS1, Line 422: if ((Resource->Io.Base + Resource->Io.Length) > 0xFFFF) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@423 PS1, Line 423: return false; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@423 PS1, Line 423: return false; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@424 PS1, Line 424: } code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@424 PS1, Line 424: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@425 PS1, Line 425: break; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@425 PS1, Line 425: break; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@427 PS1, Line 427: case PCI_CFG_RANGE: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@428 PS1, Line 428: printk(BIOS_DEBUG, "ValidateResource - PCI (0x%02x, 0x%08x, 0x%02x, 0x%02x)\n", Resource->PciCfg.OriginatingBusNumber, Resource->PciCfg.LastNodeIndex, Resource->PciCfg.PciDevicePath[0].PciDevice, Resource->PciCfg.PciDevicePath[0].PciFunction); line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@428 PS1, Line 428: printk(BIOS_DEBUG, "ValidateResource - PCI (0x%02x, 0x%08x, 0x%02x, 0x%02x)\n", Resource->PciCfg.OriginatingBusNumber, Resource->PciCfg.LastNodeIndex, Resource->PciCfg.PciDevicePath[0].PciDevice, Resource->PciCfg.PciDevicePath[0].PciFunction); code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@428 PS1, Line 428: printk(BIOS_DEBUG, "ValidateResource - PCI (0x%02x, 0x%08x, 0x%02x, 0x%02x)\n", Resource->PciCfg.OriginatingBusNumber, Resource->PciCfg.LastNodeIndex, Resource->PciCfg.PciDevicePath[0].PciDevice, Resource->PciCfg.PciDevicePath[0].PciFunction); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@428 PS1, Line 428: printk(BIOS_DEBUG, "ValidateResource - PCI (0x%02x, 0x%08x, 0x%02x, 0x%02x)\n", Resource->PciCfg.OriginatingBusNumber, Resource->PciCfg.LastNodeIndex, Resource->PciCfg.PciDevicePath[0].PciDevice, Resource->PciCfg.PciDevicePath[0].PciFunction); Prefer using '"%s...", __func__' to using 'ValidateResource', this function's name, in a string
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@429 PS1, Line 429: if (Resource->Header.Length != sizeof (STM_RSC_PCI_CFG_DESC) + (sizeof(STM_PCI_DEVICE_PATH_NODE) * Resource->PciCfg.LastNodeIndex)) { line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@429 PS1, Line 429: if (Resource->Header.Length != sizeof (STM_RSC_PCI_CFG_DESC) + (sizeof(STM_PCI_DEVICE_PATH_NODE) * Resource->PciCfg.LastNodeIndex)) { code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@429 PS1, Line 429: if (Resource->Header.Length != sizeof (STM_RSC_PCI_CFG_DESC) + (sizeof(STM_PCI_DEVICE_PATH_NODE) * Resource->PciCfg.LastNodeIndex)) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@429 PS1, Line 429: if (Resource->Header.Length != sizeof (STM_RSC_PCI_CFG_DESC) + (sizeof(STM_PCI_DEVICE_PATH_NODE) * Resource->PciCfg.LastNodeIndex)) { suspect code indent for conditional statements (8, 10)
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@429 PS1, Line 429: if (Resource->Header.Length != sizeof (STM_RSC_PCI_CFG_DESC) + (sizeof(STM_PCI_DEVICE_PATH_NODE) * Resource->PciCfg.LastNodeIndex)) { space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@429 PS1, Line 429: if (Resource->Header.Length != sizeof (STM_RSC_PCI_CFG_DESC) + (sizeof(STM_PCI_DEVICE_PATH_NODE) * Resource->PciCfg.LastNodeIndex)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@430 PS1, Line 430: return false; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@430 PS1, Line 430: return false; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@431 PS1, Line 431: } code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@431 PS1, Line 431: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@432 PS1, Line 432: for (SubIndex = 0; SubIndex <= Resource->PciCfg.LastNodeIndex; SubIndex++) { line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@432 PS1, Line 432: for (SubIndex = 0; SubIndex <= Resource->PciCfg.LastNodeIndex; SubIndex++) { code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@432 PS1, Line 432: for (SubIndex = 0; SubIndex <= Resource->PciCfg.LastNodeIndex; SubIndex++) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@432 PS1, Line 432: for (SubIndex = 0; SubIndex <= Resource->PciCfg.LastNodeIndex; SubIndex++) { suspect code indent for conditional statements (8, 10)
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@433 PS1, Line 433: if ((Resource->PciCfg.PciDevicePath[SubIndex].PciDevice > 0x1F) || (Resource->PciCfg.PciDevicePath[SubIndex].PciFunction > 7)) { line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@433 PS1, Line 433: if ((Resource->PciCfg.PciDevicePath[SubIndex].PciDevice > 0x1F) || (Resource->PciCfg.PciDevicePath[SubIndex].PciFunction > 7)) { code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@433 PS1, Line 433: if ((Resource->PciCfg.PciDevicePath[SubIndex].PciDevice > 0x1F) || (Resource->PciCfg.PciDevicePath[SubIndex].PciFunction > 7)) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@433 PS1, Line 433: if ((Resource->PciCfg.PciDevicePath[SubIndex].PciDevice > 0x1F) || (Resource->PciCfg.PciDevicePath[SubIndex].PciFunction > 7)) { suspect code indent for conditional statements (10, 12)
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@433 PS1, Line 433: if ((Resource->PciCfg.PciDevicePath[SubIndex].PciDevice > 0x1F) || (Resource->PciCfg.PciDevicePath[SubIndex].PciFunction > 7)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@434 PS1, Line 434: return false; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@434 PS1, Line 434: return false; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@435 PS1, Line 435: } code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@435 PS1, Line 435: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@436 PS1, Line 436: } code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@436 PS1, Line 436: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@437 PS1, Line 437: if ((Resource->PciCfg.Base + Resource->PciCfg.Length) > 0x1000) { code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@437 PS1, Line 437: if ((Resource->PciCfg.Base + Resource->PciCfg.Length) > 0x1000) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@437 PS1, Line 437: if ((Resource->PciCfg.Base + Resource->PciCfg.Length) > 0x1000) { suspect code indent for conditional statements (8, 10)
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@437 PS1, Line 437: if ((Resource->PciCfg.Base + Resource->PciCfg.Length) > 0x1000) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@438 PS1, Line 438: return false; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@438 PS1, Line 438: return false; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@439 PS1, Line 439: } code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@439 PS1, Line 439: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@440 PS1, Line 440: break; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@440 PS1, Line 440: break; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@442 PS1, Line 442: case MACHINE_SPECIFIC_REG: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@443 PS1, Line 443: if (Resource->Header.Length != sizeof (STM_RSC_MSR_DESC)) { code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@443 PS1, Line 443: if (Resource->Header.Length != sizeof (STM_RSC_MSR_DESC)) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@443 PS1, Line 443: if (Resource->Header.Length != sizeof (STM_RSC_MSR_DESC)) { suspect code indent for conditional statements (8, 10)
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@443 PS1, Line 443: if (Resource->Header.Length != sizeof (STM_RSC_MSR_DESC)) { space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@443 PS1, Line 443: if (Resource->Header.Length != sizeof (STM_RSC_MSR_DESC)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@444 PS1, Line 444: return false; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@444 PS1, Line 444: return false; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@445 PS1, Line 445: } code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@445 PS1, Line 445: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@446 PS1, Line 446: break; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@446 PS1, Line 446: break; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@447 PS1, Line 447: trailing whitespace
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@447 PS1, Line 447: code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@447 PS1, Line 447: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@448 PS1, Line 448: default : trailing whitespace
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@448 PS1, Line 448: default : please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@448 PS1, Line 448: default : space prohibited before that ':' (ctx:WxW)
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@449 PS1, Line 449: printk(BIOS_DEBUG, "ValidateResource - Unknown RscType(%x)\n", Resource->Header.RscType); line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@449 PS1, Line 449: printk(BIOS_DEBUG, "ValidateResource - Unknown RscType(%x)\n", Resource->Header.RscType); code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@449 PS1, Line 449: printk(BIOS_DEBUG, "ValidateResource - Unknown RscType(%x)\n", Resource->Header.RscType); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@449 PS1, Line 449: printk(BIOS_DEBUG, "ValidateResource - Unknown RscType(%x)\n", Resource->Header.RscType); Prefer using '"%s...", __func__' to using 'ValidateResource', this function's name, in a string
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@450 PS1, Line 450: return false; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@450 PS1, Line 450: return false; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@451 PS1, Line 451: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@452 PS1, Line 452: Resource = (STM_RSC *)((void *)Resource + Resource->Header.Length); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@453 PS1, Line 453: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@454 PS1, Line 454: return true; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@464 PS1, Line 464: If 0, list must be terminated by END_OF_RESOURCES. code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@471 PS1, Line 471: GetResourceSize ( space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@472 PS1, Line 472: STM_RSC *ResourceList, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@473 PS1, Line 473: uint32_t NumEntries please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@474 PS1, Line 474: ) please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@476 PS1, Line 476: uint32_t Count; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@477 PS1, Line 477: UINTN Index; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@478 PS1, Line 478: STM_RSC *Resource; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@480 PS1, Line 480: Resource = ResourceList; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@484 PS1, Line 484: // END_OF_RESOURCES. trailing whitespace
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@485 PS1, Line 485: // trailing whitespace
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@486 PS1, Line 486: if (NumEntries == 0) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@486 PS1, Line 486: if (NumEntries == 0) { suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@486 PS1, Line 486: if (NumEntries == 0) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@487 PS1, Line 487: Count = 0xFFFFFFFF; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@488 PS1, Line 488: } else { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@488 PS1, Line 488: } else { suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@489 PS1, Line 489: Count = NumEntries; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@490 PS1, Line 490: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@494 PS1, Line 494: // trailing whitespace
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@495 PS1, Line 495: Resource = ResourceList; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@496 PS1, Line 496: trailing whitespace
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@496 PS1, Line 496: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@497 PS1, Line 497: for (Index = 0; Index < Count; Index++) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@497 PS1, Line 497: for (Index = 0; Index < Count; Index++) { suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@498 PS1, Line 498: if (Resource->Header.RscType == END_OF_RESOURCES) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@498 PS1, Line 498: if (Resource->Header.RscType == END_OF_RESOURCES) { suspect code indent for conditional statements (4, 6)
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@498 PS1, Line 498: if (Resource->Header.RscType == END_OF_RESOURCES) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@499 PS1, Line 499: break; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@500 PS1, Line 500: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@501 PS1, Line 501: Resource = (STM_RSC *)((void *)Resource + Resource->Header.Length); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@502 PS1, Line 502: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@503 PS1, Line 503: return (UINTN)((uint32_t)Resource - (uint32_t) ResourceList); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@512 PS1, Line 512: If 0, list must be terminated by END_OF_RESOURCES. code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@516 PS1, Line 516: @retval EFI_OUT_OF_RESOURCES If nested procedure returned it and we cannot allocate more areas. line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@520 PS1, Line 520: AddPiResource ( space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@521 PS1, Line 521: STM_RSC *ResourceList, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@522 PS1, Line 522: uint32_t NumEntries please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@523 PS1, Line 523: ) please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@526 PS1, Line 526: UINTN ResourceSize; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@530 PS1, Line 530: printk (BIOS_DEBUG, "AddPiResource - Enter\n"); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@530 PS1, Line 530: printk (BIOS_DEBUG, "AddPiResource - Enter\n"); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@530 PS1, Line 530: printk (BIOS_DEBUG, "AddPiResource - Enter\n"); Prefer using '"%s...", __func__' to using 'AddPiResource', this function's name, in a string
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@532 PS1, Line 532: if (!ValidateResource (ResourceList, NumEntries)) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@532 PS1, Line 532: if (!ValidateResource (ResourceList, NumEntries)) { suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@532 PS1, Line 532: if (!ValidateResource (ResourceList, NumEntries)) { space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@532 PS1, Line 532: if (!ValidateResource (ResourceList, NumEntries)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@533 PS1, Line 533: return -1; //EFI_INVALID_PARAMETER; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@534 PS1, Line 534: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@536 PS1, Line 536: ResourceSize = GetResourceSize (ResourceList, NumEntries); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@536 PS1, Line 536: ResourceSize = GetResourceSize (ResourceList, NumEntries); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@537 PS1, Line 537: printk (BIOS_DEBUG, "ResourceSize - 0x%08llx\n", ResourceSize); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@537 PS1, Line 537: printk (BIOS_DEBUG, "ResourceSize - 0x%08llx\n", ResourceSize); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@538 PS1, Line 538: if (ResourceSize == 0) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@538 PS1, Line 538: if (ResourceSize == 0) { suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@538 PS1, Line 538: if (ResourceSize == 0) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@539 PS1, Line 539: return -1;//EFI_INVALID_PARAMETER; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@540 PS1, Line 540: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@542 PS1, Line 542: if (mStmResourcesPtr == NULL) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@542 PS1, Line 542: if (mStmResourcesPtr == NULL) { suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@544 PS1, Line 544: // Copy EndResource for intialization 'intialization' may be misspelled - perhaps 'initialization'?
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@549 PS1, Line 549: mStmResourcesPtr = StmResourceHeap; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@550 PS1, Line 550: mStmResourceTotalSize = RESOURCEHEAPSIZE; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@551 PS1, Line 551: memset(mStmResourcesPtr, 0, RESOURCEHEAPSIZE); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@553 PS1, Line 553: memcpy (mStmResourcesPtr, &mRscEndNode, sizeof(mRscEndNode)); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@553 PS1, Line 553: memcpy (mStmResourcesPtr, &mRscEndNode, sizeof(mRscEndNode)); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@554 PS1, Line 554: mStmResourceSizeUsed = sizeof(mRscEndNode); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@555 PS1, Line 555: mStmResourceSizeAvailable = mStmResourceTotalSize - sizeof(mRscEndNode); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@561 PS1, Line 561: } else if (mStmResourceSizeAvailable < ResourceSize) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@567 PS1, Line 567: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@572 PS1, Line 572: AddResource (ResourceList, NumEntries); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@572 PS1, Line 572: AddResource (ResourceList, NumEntries); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@574 PS1, Line 574: return 0;//EFI_SUCCESS; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@582 PS1, Line 582: NULL means delete all resources. code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@584 PS1, Line 584: If 0, list must be terminated by END_OF_RESOURCES. code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@591 PS1, Line 591: DeletePiResource ( space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@592 PS1, Line 592: STM_RSC *ResourceList, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@593 PS1, Line 593: uint32_t NumEntries please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@594 PS1, Line 594: ) please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@596 PS1, Line 596: if (ResourceList != NULL) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@596 PS1, Line 596: if (ResourceList != NULL) { suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@599 PS1, Line 599: return -1;//EFI_UNSUPPORTED; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@600 PS1, Line 600: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@604 PS1, Line 604: memcpy (mStmResourcesPtr, &mRscEndNode, sizeof(mRscEndNode)); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@604 PS1, Line 604: memcpy (mStmResourcesPtr, &mRscEndNode, sizeof(mRscEndNode)); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@605 PS1, Line 605: mStmResourceSizeUsed = sizeof(mRscEndNode); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@606 PS1, Line 606: mStmResourceSizeAvailable = mStmResourceTotalSize - sizeof(mRscEndNode); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@607 PS1, Line 607: return 0;//EFI_SUCCESS; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@616 PS1, Line 616: On output it means size of resource list filled, code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@617 PS1, Line 617: or the size of resource list to be filled if size of too small. line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@617 PS1, Line 617: or the size of resource list to be filled if size of too small. code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@620 PS1, Line 620: @retval EFI_BUFFER_TOO_SMALL If resource list buffer is too small to hold the whole resources. line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@624 PS1, Line 624: GetPiResource ( space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@625 PS1, Line 625: STM_RSC *ResourceList, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@626 PS1, Line 626: uint32_t *ResourceSize please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@627 PS1, Line 627: ) please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@629 PS1, Line 629: if (*ResourceSize < mStmResourceSizeUsed) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@629 PS1, Line 629: if (*ResourceSize < mStmResourceSizeUsed) { suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@630 PS1, Line 630: *ResourceSize = (uint32_t)mStmResourceSizeUsed; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@631 PS1, Line 631: return -1;//EFI_BUFFER_TOO_SMALL; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@632 PS1, Line 632: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@634 PS1, Line 634: memcpy (ResourceList, mStmResourcesPtr, mStmResourceSizeUsed); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@634 PS1, Line 634: memcpy (ResourceList, mStmResourcesPtr, mStmResourceSizeUsed); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@635 PS1, Line 635: *ResourceSize = (uint32_t)mStmResourceSizeUsed; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@636 PS1, Line 636: return 0;//EFI_SUCCESS; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@645 PS1, Line 645: GetVmcsSize ( space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@646 PS1, Line 646: void please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@647 PS1, Line 647: ) please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@649 PS1, Line 649: uint32_t ThisVmcsSize; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@650 PS1, Line 650: VMX_BASIC_MSR MsrData64; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@651 PS1, Line 651: int StmSupport; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@653 PS1, Line 653: MsrData64.msr = rdmsr (IA32_VMX_BASIC_MSR_INDEX); trailing whitespace
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@653 PS1, Line 653: MsrData64.msr = rdmsr (IA32_VMX_BASIC_MSR_INDEX); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@653 PS1, Line 653: MsrData64.msr = rdmsr (IA32_VMX_BASIC_MSR_INDEX); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@655 PS1, Line 655: ThisVmcsSize = MsrData64.bits.VmcsSize; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@656 PS1, Line 656: StmSupport = MsrData64.bits.StmSupported; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@657 PS1, Line 657: printk(BIOS_DEBUG, "GetVmcsSize: Size %d StmSupport %d\n", ThisVmcsSize, StmSupport); line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@657 PS1, Line 657: printk(BIOS_DEBUG, "GetVmcsSize: Size %d StmSupport %d\n", ThisVmcsSize, StmSupport); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@657 PS1, Line 657: printk(BIOS_DEBUG, "GetVmcsSize: Size %d StmSupport %d\n", ThisVmcsSize, StmSupport); Prefer using '"%s...", __func__' to using 'GetVmcsSize', this function's name, in a string
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@662 PS1, Line 662: ThisVmcsSize = STM_PAGES_TO_SIZE (STM_SIZE_TO_PAGES (ThisVmcsSize)); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@662 PS1, Line 662: ThisVmcsSize = STM_PAGES_TO_SIZE (STM_SIZE_TO_PAGES (ThisVmcsSize)); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@662 PS1, Line 662: ThisVmcsSize = STM_PAGES_TO_SIZE (STM_SIZE_TO_PAGES (ThisVmcsSize)); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@664 PS1, Line 664: return ThisVmcsSize; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@676 PS1, Line 676: StmGen4GPageTableIa32 ( space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@677 PS1, Line 677: uint32_t PageTableBase please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@678 PS1, Line 678: ) please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@680 PS1, Line 680: UINTN Index; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@681 PS1, Line 681: uint32_t *Pte; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@682 PS1, Line 682: uint32_t Address; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@684 PS1, Line 684: Pte = (uint32_t*)(uint32_t)PageTableBase; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@684 PS1, Line 684: Pte = (uint32_t*)(uint32_t)PageTableBase; "(foo*)" should be "(foo *)"
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@686 PS1, Line 686: Address = 0; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@687 PS1, Line 687: for (Index = 0; Index < SIZE_4KB / sizeof (*Pte); Index++) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@687 PS1, Line 687: for (Index = 0; Index < SIZE_4KB / sizeof (*Pte); Index++) { suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@687 PS1, Line 687: for (Index = 0; Index < SIZE_4KB / sizeof (*Pte); Index++) { space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@688 PS1, Line 688: *Pte = Address | IA32_PG_PS | IA32_PG_RW | IA32_PG_P; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@689 PS1, Line 689: Pte++; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@690 PS1, Line 690: Address += SIZE_4MB; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@691 PS1, Line 691: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@693 PS1, Line 693: return ; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@693 PS1, Line 693: return ; space prohibited before semicolon
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@705 PS1, Line 705: StmGen4GPageTableX64 ( space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@706 PS1, Line 706: uint32_t PageTableBase please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@707 PS1, Line 707: ) please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@709 PS1, Line 709: UINTN Index; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@710 PS1, Line 710: UINTN SubIndex; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@711 PS1, Line 711: uint64_t *Pde; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@712 PS1, Line 712: uint64_t *Pte; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@713 PS1, Line 713: uint64_t *Pml4; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@715 PS1, Line 715: Pml4 = (uint64_t*)(uint32_t) PageTableBase; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@715 PS1, Line 715: Pml4 = (uint64_t*)(uint32_t) PageTableBase; "(foo*)" should be "(foo *)"
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@716 PS1, Line 716: PageTableBase += SIZE_4KB; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@717 PS1, Line 717: *Pml4 = PageTableBase | IA32_PG_RW | IA32_PG_P; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@719 PS1, Line 719: Pde = (uint64_t*)(uint32_t)PageTableBase; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@719 PS1, Line 719: Pde = (uint64_t*)(uint32_t)PageTableBase; "(foo*)" should be "(foo *)"
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@720 PS1, Line 720: PageTableBase += SIZE_4KB; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@721 PS1, Line 721: Pte = (uint64_t *)(uint32_t)PageTableBase; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@723 PS1, Line 723: for (Index = 0; Index < 4; Index++) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@723 PS1, Line 723: for (Index = 0; Index < 4; Index++) { suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@724 PS1, Line 724: *Pde = PageTableBase | IA32_PG_RW | IA32_PG_P; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@725 PS1, Line 725: Pde++; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@726 PS1, Line 726: PageTableBase += SIZE_4KB; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@728 PS1, Line 728: for (SubIndex = 0; SubIndex < SIZE_4KB / sizeof (*Pte); SubIndex++) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@728 PS1, Line 728: for (SubIndex = 0; SubIndex < SIZE_4KB / sizeof (*Pte); SubIndex++) { suspect code indent for conditional statements (4, 6)
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@728 PS1, Line 728: for (SubIndex = 0; SubIndex < SIZE_4KB / sizeof (*Pte); SubIndex++) { space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@729 PS1, Line 729: *Pte = (((Index << 9) + SubIndex) << 21) | IA32_PG_PS | IA32_PG_RW | IA32_PG_P; line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@729 PS1, Line 729: *Pte = (((Index << 9) + SubIndex) << 21) | IA32_PG_PS | IA32_PG_RW | IA32_PG_P; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@730 PS1, Line 730: Pte++; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@731 PS1, Line 731: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@732 PS1, Line 732: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@734 PS1, Line 734: return ; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@734 PS1, Line 734: return ; space prohibited before semicolon
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@748 PS1, Line 748: bool StmCheckStmImage ( space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@749 PS1, Line 749: void * StmImage, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@749 PS1, Line 749: void * StmImage, "foo * bar" should be "foo *bar"
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@750 PS1, Line 750: uint32_t StmImageSize please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@751 PS1, Line 751: ) please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@753 PS1, Line 753: UINTN MinMsegSize; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@754 PS1, Line 754: STM_HEADER *StmHeader; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@756 PS1, Line 756: StmHeader = (STM_HEADER *)StmImage; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@761 PS1, Line 761: MinMsegSize = (STM_PAGES_TO_SIZE (STM_SIZE_TO_PAGES (StmHeader->SwStmHdr.StaticImageSize)) + line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@761 PS1, Line 761: MinMsegSize = (STM_PAGES_TO_SIZE (STM_SIZE_TO_PAGES (StmHeader->SwStmHdr.StaticImageSize)) + please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@761 PS1, Line 761: MinMsegSize = (STM_PAGES_TO_SIZE (STM_SIZE_TO_PAGES (StmHeader->SwStmHdr.StaticImageSize)) + space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@761 PS1, Line 761: MinMsegSize = (STM_PAGES_TO_SIZE (STM_SIZE_TO_PAGES (StmHeader->SwStmHdr.StaticImageSize)) + space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@762 PS1, Line 762: StmHeader->SwStmHdr.AdditionalDynamicMemorySize + code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@762 PS1, Line 762: StmHeader->SwStmHdr.AdditionalDynamicMemorySize + please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@763 PS1, Line 763: (StmHeader->SwStmHdr.PerProcDynamicMemorySize + GetVmcsSize () * 2) * mp_state.cpu_count); line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@763 PS1, Line 763: (StmHeader->SwStmHdr.PerProcDynamicMemorySize + GetVmcsSize () * 2) * mp_state.cpu_count); code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@763 PS1, Line 763: (StmHeader->SwStmHdr.PerProcDynamicMemorySize + GetVmcsSize () * 2) * mp_state.cpu_count); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@763 PS1, Line 763: (StmHeader->SwStmHdr.PerProcDynamicMemorySize + GetVmcsSize () * 2) * mp_state.cpu_count); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@764 PS1, Line 764: if (MinMsegSize < StmImageSize) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@764 PS1, Line 764: if (MinMsegSize < StmImageSize) { suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@764 PS1, Line 764: if (MinMsegSize < StmImageSize) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@765 PS1, Line 765: MinMsegSize = StmImageSize; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@766 PS1, Line 766: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@768 PS1, Line 768: if (StmHeader->HwStmHdr.Cr3Offset >= StmHeader->SwStmHdr.StaticImageSize) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@768 PS1, Line 768: if (StmHeader->HwStmHdr.Cr3Offset >= StmHeader->SwStmHdr.StaticImageSize) { suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@772 PS1, Line 772: if (MinMsegSize < StmHeader->HwStmHdr.Cr3Offset + STM_PAGES_TO_SIZE(6)) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@772 PS1, Line 772: if (MinMsegSize < StmHeader->HwStmHdr.Cr3Offset + STM_PAGES_TO_SIZE(6)) { suspect code indent for conditional statements (4, 6)
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@772 PS1, Line 772: if (MinMsegSize < StmHeader->HwStmHdr.Cr3Offset + STM_PAGES_TO_SIZE(6)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@773 PS1, Line 773: MinMsegSize = StmHeader->HwStmHdr.Cr3Offset + STM_PAGES_TO_SIZE(6); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@774 PS1, Line 774: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@775 PS1, Line 775: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@780 PS1, Line 780: if (MinMsegSize > CONFIG_MSEG_SIZE) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@780 PS1, Line 780: if (MinMsegSize > CONFIG_MSEG_SIZE) { suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@780 PS1, Line 780: if (MinMsegSize > CONFIG_MSEG_SIZE) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@781 PS1, Line 781: return false; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@782 PS1, Line 782: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@784 PS1, Line 784: return true; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@798 PS1, Line 798: StmLoadStmImage ( space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@799 PS1, Line 799: void * StmImage, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@799 PS1, Line 799: void * StmImage, "foo * bar" should be "foo *bar"
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@800 PS1, Line 800: UINTN StmImageSize please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@801 PS1, Line 801: ) please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@803 PS1, Line 803: uint32_t MsegBase; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@804 PS1, Line 804: STM_HEADER *StmHeader; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@805 PS1, Line 805: SMM_MONITOR_CTL_MSR SmmMonitorMsr; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@807 PS1, Line 807: StmHeader = (STM_HEADER *)(uint32_t)StmImage; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@808 PS1, Line 808: SmmMonitorMsr.msr = rdmsr(IA32_SMM_MONITOR_CTL_MSR_INDEX); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@809 PS1, Line 809: MsegBase = SmmMonitorMsr.bits.MsegAddress << 12; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@813 PS1, Line 813: memset((void *) MsegBase, 0, CONFIG_MSEG_SIZE); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@814 PS1, Line 814: //memcpy ((void *)(uint32_t)MsegBase, (void *)(uint32_t)StmImage, StmImageSize); line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@815 PS1, Line 815: memcpy((void *) MsegBase, (void *) StmImage, (size_t) StmImageSize); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@818 PS1, Line 818: if (sizeof(UINTN) == sizeof(uint64_t)) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@818 PS1, Line 818: if (sizeof(UINTN) == sizeof(uint64_t)) { suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@818 PS1, Line 818: if (sizeof(UINTN) == sizeof(uint64_t)) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@819 PS1, Line 819: StmGen4GPageTableX64 ((UINTN)MsegBase + StmHeader->HwStmHdr.Cr3Offset); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@819 PS1, Line 819: StmGen4GPageTableX64 ((UINTN)MsegBase + StmHeader->HwStmHdr.Cr3Offset); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@820 PS1, Line 820: } else { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@820 PS1, Line 820: } else { suspect code indent for conditional statements (1, 4)
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@821 PS1, Line 821: StmGen4GPageTableIa32 ((UINTN)MsegBase + StmHeader->HwStmHdr.Cr3Offset); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@821 PS1, Line 821: StmGen4GPageTableIa32 ((UINTN)MsegBase + StmHeader->HwStmHdr.Cr3Offset); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@822 PS1, Line 822: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@837 PS1, Line 837: @retval EFI_BUFFER_TOO_SMALL MSEG is smaller than minimal requirement of STM image line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@841 PS1, Line 841: int LoadMonitor ( space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@842 PS1, Line 842: void * StmImage, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@842 PS1, Line 842: void * StmImage, "foo * bar" should be "foo *bar"
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@843 PS1, Line 843: uint32_t StmImageSize please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@844 PS1, Line 844: ) please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@846 PS1, Line 846: SMM_MONITOR_CTL_MSR SmmMonCtlMsr; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@848 PS1, Line 848: SmmMonCtlMsr.msr = (msr_t) rdmsr(IA32_SMM_MONITOR_CTL_MSR_INDEX); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@850 PS1, Line 850: if (SmmMonCtlMsr.bits.MsegAddress == 0) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@850 PS1, Line 850: if (SmmMonCtlMsr.bits.MsegAddress == 0) { suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@850 PS1, Line 850: if (SmmMonCtlMsr.bits.MsegAddress == 0) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@851 PS1, Line 851: return STM_UNSUPPORTED; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@852 PS1, Line 852: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@853 PS1, Line 853: if (SmmMonCtlMsr.bits.valid != 0) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@853 PS1, Line 853: if (SmmMonCtlMsr.bits.valid != 0) { suspect code indent for conditional statements (2, 2)
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@856 PS1, Line 856: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@858 PS1, Line 858: if (!StmCheckStmImage (StmImage, StmImageSize)) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@858 PS1, Line 858: if (!StmCheckStmImage (StmImage, StmImageSize)) { suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@858 PS1, Line 858: if (!StmCheckStmImage (StmImage, StmImageSize)) { space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@858 PS1, Line 858: if (!StmCheckStmImage (StmImage, StmImageSize)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@859 PS1, Line 859: return STM_BUFFER_TOO_SMALL; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@860 PS1, Line 860: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@863 PS1, Line 863: // Record STM_HASH to PCR 0, just in case it is NOT TXT launch, we still need provide the evidence. line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@864 PS1, Line 864: TpmMeasureAndLogData( please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@865 PS1, Line 865: 0, // PcrIndex please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@866 PS1, Line 866: TXT_EVTYPE_STM_HASH, // EventType please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@867 PS1, Line 867: NULL, // EventLog please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@868 PS1, Line 868: 0, // LogLen please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@869 PS1, Line 869: (void *)StmImage, // HashData please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@870 PS1, Line 870: StmImageSize // HashDataLen please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@871 PS1, Line 871: ); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@873 PS1, Line 873: StmLoadStmImage (StmImage, StmImageSize); please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@873 PS1, Line 873: StmLoadStmImage (StmImage, StmImageSize); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@874 PS1, Line 874: trailing whitespace
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@874 PS1, Line 874: code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@874 PS1, Line 874: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@875 PS1, Line 875: mStmState |= STM_SM_MONITOR_STATE_ENABLED; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@877 PS1, Line 877: return STM_SUCCESS; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@889 PS1, Line 889: void please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@890 PS1, Line 890: ) please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/SmmStm.c@892 PS1, Line 892: return mStmResourcesPtr; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h File src/security/intel/stm/StmApi.h:
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@7 PS1, Line 7: distribution. The full text of the license may be found at trailing whitespace
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@27 PS1, Line 27: #pragma pack (push, 1) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@31 PS1, Line 31: uint32_t StmHeaderRevision; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@31 PS1, Line 31: uint32_t StmHeaderRevision; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@31 PS1, Line 31: uint32_t StmHeaderRevision; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@32 PS1, Line 32: uint32_t MonitorFeatures; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@32 PS1, Line 32: uint32_t MonitorFeatures; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@32 PS1, Line 32: uint32_t MonitorFeatures; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@33 PS1, Line 33: uint32_t GdtrLimit; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@33 PS1, Line 33: uint32_t GdtrLimit; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@33 PS1, Line 33: uint32_t GdtrLimit; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@34 PS1, Line 34: uint32_t GdtrBaseOffset; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@34 PS1, Line 34: uint32_t GdtrBaseOffset; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@34 PS1, Line 34: uint32_t GdtrBaseOffset; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@35 PS1, Line 35: uint32_t CsSelector; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@35 PS1, Line 35: uint32_t CsSelector; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@35 PS1, Line 35: uint32_t CsSelector; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@36 PS1, Line 36: uint32_t EipOffset; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@36 PS1, Line 36: uint32_t EipOffset; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@36 PS1, Line 36: uint32_t EipOffset; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@37 PS1, Line 37: uint32_t EspOffset; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@37 PS1, Line 37: uint32_t EspOffset; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@37 PS1, Line 37: uint32_t EspOffset; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@38 PS1, Line 38: uint32_t Cr3Offset; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@38 PS1, Line 38: uint32_t Cr3Offset; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@38 PS1, Line 38: uint32_t Cr3Offset; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@39 PS1, Line 39: uint8_t Reserved[STM_HARDWARE_FIELD_FILL_TO_2K]; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@39 PS1, Line 39: uint8_t Reserved[STM_HARDWARE_FIELD_FILL_TO_2K]; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@39 PS1, Line 39: uint8_t Reserved[STM_HARDWARE_FIELD_FILL_TO_2K]; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@45 PS1, Line 45: uint32_t Intel64ModeSupported :1; // bitfield code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@45 PS1, Line 45: uint32_t Intel64ModeSupported :1; // bitfield please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@45 PS1, Line 45: uint32_t Intel64ModeSupported :1; // bitfield please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@46 PS1, Line 46: uint32_t EptSupported :1; // bitfield code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@46 PS1, Line 46: uint32_t EptSupported :1; // bitfield please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@46 PS1, Line 46: uint32_t EptSupported :1; // bitfield please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@47 PS1, Line 47: uint32_t Reserved :30; // must be 0 code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@47 PS1, Line 47: uint32_t Reserved :30; // must be 0 please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@47 PS1, Line 47: uint32_t Reserved :30; // must be 0 please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@51 PS1, Line 51: uint8_t StmSpecVerMajor; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@51 PS1, Line 51: uint8_t StmSpecVerMajor; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@51 PS1, Line 51: uint8_t StmSpecVerMajor; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@52 PS1, Line 52: uint8_t StmSpecVerMinor; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@52 PS1, Line 52: uint8_t StmSpecVerMinor; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@52 PS1, Line 52: uint8_t StmSpecVerMinor; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@53 PS1, Line 53: uint16_t Reserved; // must be zero code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@53 PS1, Line 53: uint16_t Reserved; // must be zero please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@53 PS1, Line 53: uint16_t Reserved; // must be zero please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@54 PS1, Line 54: uint32_t StaticImageSize; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@54 PS1, Line 54: uint32_t StaticImageSize; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@54 PS1, Line 54: uint32_t StaticImageSize; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@55 PS1, Line 55: uint32_t PerProcDynamicMemorySize; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@55 PS1, Line 55: uint32_t PerProcDynamicMemorySize; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@55 PS1, Line 55: uint32_t PerProcDynamicMemorySize; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@56 PS1, Line 56: uint32_t AdditionalDynamicMemorySize; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@56 PS1, Line 56: uint32_t AdditionalDynamicMemorySize; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@56 PS1, Line 56: uint32_t AdditionalDynamicMemorySize; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@57 PS1, Line 57: STM_FEAT StmFeatures; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@57 PS1, Line 57: STM_FEAT StmFeatures; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@57 PS1, Line 57: STM_FEAT StmFeatures; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@58 PS1, Line 58: uint32_t NumberOfRevIDs; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@58 PS1, Line 58: uint32_t NumberOfRevIDs; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@58 PS1, Line 58: uint32_t NumberOfRevIDs; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@59 PS1, Line 59: uint32_t StmSmmRevID[1]; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@59 PS1, Line 59: uint32_t StmSmmRevID[1]; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@59 PS1, Line 59: uint32_t StmSmmRevID[1]; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@66 PS1, Line 66: HARDWARE_STM_HEADER HwStmHdr; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@66 PS1, Line 66: HARDWARE_STM_HEADER HwStmHdr; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@66 PS1, Line 66: HARDWARE_STM_HEADER HwStmHdr; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@67 PS1, Line 67: SOFTWARE_STM_HEADER SwStmHdr; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@67 PS1, Line 67: SOFTWARE_STM_HEADER SwStmHdr; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@67 PS1, Line 67: SOFTWARE_STM_HEADER SwStmHdr; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@73 PS1, Line 73: uint64_t BiosComponentBase; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@73 PS1, Line 73: uint64_t BiosComponentBase; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@73 PS1, Line 73: uint64_t BiosComponentBase; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@74 PS1, Line 74: uint32_t ImageSize; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@74 PS1, Line 74: uint32_t ImageSize; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@74 PS1, Line 74: uint32_t ImageSize; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@75 PS1, Line 75: uint32_t HashAlgorithm; // SHA1 or SHA256 code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@75 PS1, Line 75: uint32_t HashAlgorithm; // SHA1 or SHA256 please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@75 PS1, Line 75: uint32_t HashAlgorithm; // SHA1 or SHA256 please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@76 PS1, Line 76: uint8_t Hash[32]; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@76 PS1, Line 76: uint8_t Hash[32]; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@76 PS1, Line 76: uint8_t Hash[32]; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@81 PS1, Line 81: uint32_t ImageSize; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@81 PS1, Line 81: uint32_t ImageSize; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@81 PS1, Line 81: uint32_t ImageSize; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@82 PS1, Line 82: uint32_t Reserved; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@82 PS1, Line 82: uint32_t Reserved; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@82 PS1, Line 82: uint32_t Reserved; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@83 PS1, Line 83: uint64_t ImagePageBase[1]; //[NumberOfPages]; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@83 PS1, Line 83: uint64_t ImagePageBase[1]; //[NumberOfPages]; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@83 PS1, Line 83: uint64_t ImagePageBase[1]; //[NumberOfPages]; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@94 PS1, Line 94: uint64_t SpeRip; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@94 PS1, Line 94: uint64_t SpeRip; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@94 PS1, Line 94: uint64_t SpeRip; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@95 PS1, Line 95: uint64_t SpeRsp; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@95 PS1, Line 95: uint64_t SpeRsp; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@95 PS1, Line 95: uint64_t SpeRsp; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@96 PS1, Line 96: uint16_t SpeSs; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@96 PS1, Line 96: uint16_t SpeSs; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@96 PS1, Line 96: uint16_t SpeSs; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@97 PS1, Line 97: uint16_t PageViolationException:1; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@97 PS1, Line 97: uint16_t PageViolationException:1; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@97 PS1, Line 97: uint16_t PageViolationException:1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@98 PS1, Line 98: uint16_t MsrViolationException:1; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@98 PS1, Line 98: uint16_t MsrViolationException:1; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@98 PS1, Line 98: uint16_t MsrViolationException:1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@99 PS1, Line 99: uint16_t RegisterViolationException:1; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@99 PS1, Line 99: uint16_t RegisterViolationException:1; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@99 PS1, Line 99: uint16_t RegisterViolationException:1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@100 PS1, Line 100: uint16_t IoViolationException:1; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@100 PS1, Line 100: uint16_t IoViolationException:1; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@100 PS1, Line 100: uint16_t IoViolationException:1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@101 PS1, Line 101: uint16_t PciViolationException:1; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@101 PS1, Line 101: uint16_t PciViolationException:1; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@101 PS1, Line 101: uint16_t PciViolationException:1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@102 PS1, Line 102: uint16_t Reserved1:11; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@102 PS1, Line 102: uint16_t Reserved1:11; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@102 PS1, Line 102: uint16_t Reserved1:11; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@103 PS1, Line 103: uint32_t Reserved2; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@103 PS1, Line 103: uint32_t Reserved2; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@103 PS1, Line 103: uint32_t Reserved2; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@107 PS1, Line 107: uint8_t ExecutionDisableOutsideSmrr:1; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@107 PS1, Line 107: uint8_t ExecutionDisableOutsideSmrr:1; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@107 PS1, Line 107: uint8_t ExecutionDisableOutsideSmrr:1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@108 PS1, Line 108: uint8_t Intel64Mode:1; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@108 PS1, Line 108: uint8_t Intel64Mode:1; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@108 PS1, Line 108: uint8_t Intel64Mode:1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@109 PS1, Line 109: uint8_t Cr4Pae : 1; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@109 PS1, Line 109: uint8_t Cr4Pae : 1; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@109 PS1, Line 109: uint8_t Cr4Pae : 1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@110 PS1, Line 110: uint8_t Cr4Pse : 1; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@110 PS1, Line 110: uint8_t Cr4Pse : 1; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@110 PS1, Line 110: uint8_t Cr4Pse : 1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@111 PS1, Line 111: uint8_t Reserved1 : 4; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@111 PS1, Line 111: uint8_t Reserved1 : 4; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@111 PS1, Line 111: uint8_t Reserved1 : 4; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@115 PS1, Line 115: uint8_t SmramToVmcsRestoreRequired : 1; // BIOS restore hint code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@115 PS1, Line 115: uint8_t SmramToVmcsRestoreRequired : 1; // BIOS restore hint please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@115 PS1, Line 115: uint8_t SmramToVmcsRestoreRequired : 1; // BIOS restore hint please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@116 PS1, Line 116: uint8_t ReinitializeVmcsRequired : 1; // BIOS request code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@116 PS1, Line 116: uint8_t ReinitializeVmcsRequired : 1; // BIOS request please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@116 PS1, Line 116: uint8_t ReinitializeVmcsRequired : 1; // BIOS request please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@117 PS1, Line 117: uint8_t Reserved2 : 6; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@117 PS1, Line 117: uint8_t Reserved2 : 6; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@117 PS1, Line 117: uint8_t Reserved2 : 6; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@121 PS1, Line 121: uint8_t DomainType : 4; // STM input to BIOS on each SM code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@121 PS1, Line 121: uint8_t DomainType : 4; // STM input to BIOS on each SM please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@121 PS1, Line 121: uint8_t DomainType : 4; // STM input to BIOS on each SM please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@122 PS1, Line 122: uint8_t XStatePolicy : 2; // STM input to BIOS on each SMI code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@122 PS1, Line 122: uint8_t XStatePolicy : 2; // STM input to BIOS on each SMI please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@122 PS1, Line 122: uint8_t XStatePolicy : 2; // STM input to BIOS on each SMI please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@123 PS1, Line 123: uint8_t EptEnabled : 1; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@123 PS1, Line 123: uint8_t EptEnabled : 1; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@123 PS1, Line 123: uint8_t EptEnabled : 1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@124 PS1, Line 124: uint8_t Reserved3 : 1; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@124 PS1, Line 124: uint8_t Reserved3 : 1; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@124 PS1, Line 124: uint8_t Reserved3 : 1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@128 PS1, Line 128: uint64_t Signature; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@128 PS1, Line 128: uint64_t Signature; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@128 PS1, Line 128: uint64_t Signature; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@129 PS1, Line 129: uint16_t Size; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@129 PS1, Line 129: uint16_t Size; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@129 PS1, Line 129: uint16_t Size; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@130 PS1, Line 130: uint8_t SmmDescriptorVerMajor; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@130 PS1, Line 130: uint8_t SmmDescriptorVerMajor; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@130 PS1, Line 130: uint8_t SmmDescriptorVerMajor; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@131 PS1, Line 131: uint8_t SmmDescriptorVerMinor; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@131 PS1, Line 131: uint8_t SmmDescriptorVerMinor; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@131 PS1, Line 131: uint8_t SmmDescriptorVerMinor; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@132 PS1, Line 132: uint32_t LocalApicId; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@132 PS1, Line 132: uint32_t LocalApicId; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@132 PS1, Line 132: uint32_t LocalApicId; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@133 PS1, Line 133: STM_SMM_ENTRY_STATE SmmEntryState; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@133 PS1, Line 133: STM_SMM_ENTRY_STATE SmmEntryState; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@133 PS1, Line 133: STM_SMM_ENTRY_STATE SmmEntryState; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@134 PS1, Line 134: STM_SMM_RESUME_STATE SmmResumeState; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@134 PS1, Line 134: STM_SMM_RESUME_STATE SmmResumeState; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@134 PS1, Line 134: STM_SMM_RESUME_STATE SmmResumeState; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@135 PS1, Line 135: STM_SMM_STATE StmSmmState; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@135 PS1, Line 135: STM_SMM_STATE StmSmmState; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@135 PS1, Line 135: STM_SMM_STATE StmSmmState; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@136 PS1, Line 136: uint8_t Reserved4; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@136 PS1, Line 136: uint8_t Reserved4; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@136 PS1, Line 136: uint8_t Reserved4; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@137 PS1, Line 137: uint16_t SmmCs; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@137 PS1, Line 137: uint16_t SmmCs; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@137 PS1, Line 137: uint16_t SmmCs; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@138 PS1, Line 138: uint16_t SmmDs; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@138 PS1, Line 138: uint16_t SmmDs; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@138 PS1, Line 138: uint16_t SmmDs; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@139 PS1, Line 139: uint16_t SmmSs; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@139 PS1, Line 139: uint16_t SmmSs; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@139 PS1, Line 139: uint16_t SmmSs; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@140 PS1, Line 140: uint16_t SmmOtherSegment; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@140 PS1, Line 140: uint16_t SmmOtherSegment; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@140 PS1, Line 140: uint16_t SmmOtherSegment; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@141 PS1, Line 141: uint16_t SmmTr; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@141 PS1, Line 141: uint16_t SmmTr; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@141 PS1, Line 141: uint16_t SmmTr; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@142 PS1, Line 142: uint16_t Reserved5; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@142 PS1, Line 142: uint16_t Reserved5; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@142 PS1, Line 142: uint16_t Reserved5; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@143 PS1, Line 143: uint64_t SmmCr3; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@143 PS1, Line 143: uint64_t SmmCr3; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@143 PS1, Line 143: uint64_t SmmCr3; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@144 PS1, Line 144: uint64_t SmmStmSetupRip; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@144 PS1, Line 144: uint64_t SmmStmSetupRip; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@144 PS1, Line 144: uint64_t SmmStmSetupRip; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@145 PS1, Line 145: uint64_t SmmStmTeardownRip; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@145 PS1, Line 145: uint64_t SmmStmTeardownRip; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@145 PS1, Line 145: uint64_t SmmStmTeardownRip; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@146 PS1, Line 146: uint64_t SmmSmiHandlerRip; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@146 PS1, Line 146: uint64_t SmmSmiHandlerRip; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@146 PS1, Line 146: uint64_t SmmSmiHandlerRip; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@147 PS1, Line 147: uint64_t SmmSmiHandlerRsp; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@147 PS1, Line 147: uint64_t SmmSmiHandlerRsp; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@147 PS1, Line 147: uint64_t SmmSmiHandlerRsp; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@148 PS1, Line 148: uint64_t SmmGdtPtr; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@148 PS1, Line 148: uint64_t SmmGdtPtr; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@148 PS1, Line 148: uint64_t SmmGdtPtr; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@149 PS1, Line 149: uint32_t SmmGdtSize; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@149 PS1, Line 149: uint32_t SmmGdtSize; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@149 PS1, Line 149: uint32_t SmmGdtSize; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@150 PS1, Line 150: uint32_t RequiredStmSmmRevId; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@150 PS1, Line 150: uint32_t RequiredStmSmmRevId; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@150 PS1, Line 150: uint32_t RequiredStmSmmRevId; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@151 PS1, Line 151: STM_PROTECTION_EXCEPTION_HANDLER StmProtectionExceptionHandler; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@151 PS1, Line 151: STM_PROTECTION_EXCEPTION_HANDLER StmProtectionExceptionHandler; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@151 PS1, Line 151: STM_PROTECTION_EXCEPTION_HANDLER StmProtectionExceptionHandler; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@152 PS1, Line 152: uint64_t Reserved6; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@152 PS1, Line 152: uint64_t Reserved6; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@152 PS1, Line 152: uint64_t Reserved6; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@153 PS1, Line 153: uint64_t BiosHwResourceRequirementsPtr; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@153 PS1, Line 153: uint64_t BiosHwResourceRequirementsPtr; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@153 PS1, Line 153: uint64_t BiosHwResourceRequirementsPtr; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@155 PS1, Line 155: uint64_t AcpiRsdp; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@155 PS1, Line 155: uint64_t AcpiRsdp; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@155 PS1, Line 155: uint64_t AcpiRsdp; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@156 PS1, Line 156: uint8_t PhysicalAddressBits; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@156 PS1, Line 156: uint8_t PhysicalAddressBits; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@156 PS1, Line 156: uint8_t PhysicalAddressBits; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@166 PS1, Line 166: TxtSmmPageViolation = 1, code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@166 PS1, Line 166: TxtSmmPageViolation = 1, please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@166 PS1, Line 166: TxtSmmPageViolation = 1, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@167 PS1, Line 167: TxtSmmMsrViolation, code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@167 PS1, Line 167: TxtSmmMsrViolation, please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@167 PS1, Line 167: TxtSmmMsrViolation, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@168 PS1, Line 168: TxtSmmRegisterViolation, code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@168 PS1, Line 168: TxtSmmRegisterViolation, please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@168 PS1, Line 168: TxtSmmRegisterViolation, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@169 PS1, Line 169: TxtSmmIoViolation, code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@169 PS1, Line 169: TxtSmmIoViolation, please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@169 PS1, Line 169: TxtSmmIoViolation, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@170 PS1, Line 170: TxtSmmPciViolation code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@170 PS1, Line 170: TxtSmmPciViolation please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@170 PS1, Line 170: TxtSmmPciViolation please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@174 PS1, Line 174: uint32_t Rdi; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@174 PS1, Line 174: uint32_t Rdi; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@174 PS1, Line 174: uint32_t Rdi; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@175 PS1, Line 175: uint32_t Rsi; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@175 PS1, Line 175: uint32_t Rsi; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@175 PS1, Line 175: uint32_t Rsi; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@176 PS1, Line 176: uint32_t Rbp; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@176 PS1, Line 176: uint32_t Rbp; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@176 PS1, Line 176: uint32_t Rbp; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@177 PS1, Line 177: uint32_t Rdx; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@177 PS1, Line 177: uint32_t Rdx; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@177 PS1, Line 177: uint32_t Rdx; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@178 PS1, Line 178: uint32_t Rcx; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@178 PS1, Line 178: uint32_t Rcx; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@178 PS1, Line 178: uint32_t Rcx; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@179 PS1, Line 179: uint32_t Rbx; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@179 PS1, Line 179: uint32_t Rbx; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@179 PS1, Line 179: uint32_t Rbx; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@180 PS1, Line 180: uint32_t Rax; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@180 PS1, Line 180: uint32_t Rax; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@180 PS1, Line 180: uint32_t Rax; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@181 PS1, Line 181: uint32_t Cr3; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@181 PS1, Line 181: uint32_t Cr3; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@181 PS1, Line 181: uint32_t Cr3; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@182 PS1, Line 182: uint32_t Cr2; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@182 PS1, Line 182: uint32_t Cr2; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@182 PS1, Line 182: uint32_t Cr2; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@183 PS1, Line 183: uint32_t Cr0; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@183 PS1, Line 183: uint32_t Cr0; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@183 PS1, Line 183: uint32_t Cr0; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@184 PS1, Line 184: uint32_t VmcsExitInstructionInfo; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@184 PS1, Line 184: uint32_t VmcsExitInstructionInfo; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@184 PS1, Line 184: uint32_t VmcsExitInstructionInfo; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@185 PS1, Line 185: uint32_t VmcsExitInstructionLength; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@185 PS1, Line 185: uint32_t VmcsExitInstructionLength; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@185 PS1, Line 185: uint32_t VmcsExitInstructionLength; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@186 PS1, Line 186: uint64_t VmcsExitQualification; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@186 PS1, Line 186: uint64_t VmcsExitQualification; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@186 PS1, Line 186: uint64_t VmcsExitQualification; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@187 PS1, Line 187: uint32_t ErrorCode; // TXT_SMM_PROTECTION_EXCEPTION_TYPE code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@187 PS1, Line 187: uint32_t ErrorCode; // TXT_SMM_PROTECTION_EXCEPTION_TYPE please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@187 PS1, Line 187: uint32_t ErrorCode; // TXT_SMM_PROTECTION_EXCEPTION_TYPE please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@188 PS1, Line 188: uint32_t Rip; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@188 PS1, Line 188: uint32_t Rip; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@188 PS1, Line 188: uint32_t Rip; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@189 PS1, Line 189: uint32_t Cs; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@189 PS1, Line 189: uint32_t Cs; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@189 PS1, Line 189: uint32_t Cs; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@190 PS1, Line 190: uint32_t Rflags; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@190 PS1, Line 190: uint32_t Rflags; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@190 PS1, Line 190: uint32_t Rflags; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@191 PS1, Line 191: uint32_t Rsp; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@191 PS1, Line 191: uint32_t Rsp; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@191 PS1, Line 191: uint32_t Rsp; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@192 PS1, Line 192: uint32_t Ss; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@192 PS1, Line 192: uint32_t Ss; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@192 PS1, Line 192: uint32_t Ss; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@196 PS1, Line 196: uint64_t R15; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@196 PS1, Line 196: uint64_t R15; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@196 PS1, Line 196: uint64_t R15; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@197 PS1, Line 197: uint64_t R14; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@197 PS1, Line 197: uint64_t R14; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@197 PS1, Line 197: uint64_t R14; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@198 PS1, Line 198: uint64_t R13; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@198 PS1, Line 198: uint64_t R13; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@198 PS1, Line 198: uint64_t R13; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@199 PS1, Line 199: uint64_t R12; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@199 PS1, Line 199: uint64_t R12; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@199 PS1, Line 199: uint64_t R12; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@200 PS1, Line 200: uint64_t R11; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@200 PS1, Line 200: uint64_t R11; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@200 PS1, Line 200: uint64_t R11; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@201 PS1, Line 201: uint64_t R10; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@201 PS1, Line 201: uint64_t R10; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@201 PS1, Line 201: uint64_t R10; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@202 PS1, Line 202: uint64_t R9; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@202 PS1, Line 202: uint64_t R9; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@202 PS1, Line 202: uint64_t R9; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@203 PS1, Line 203: uint64_t R8; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@203 PS1, Line 203: uint64_t R8; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@203 PS1, Line 203: uint64_t R8; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@204 PS1, Line 204: uint64_t Rdi; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@204 PS1, Line 204: uint64_t Rdi; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@204 PS1, Line 204: uint64_t Rdi; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@205 PS1, Line 205: uint64_t Rsi; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@205 PS1, Line 205: uint64_t Rsi; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@205 PS1, Line 205: uint64_t Rsi; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@206 PS1, Line 206: uint64_t Rbp; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@206 PS1, Line 206: uint64_t Rbp; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@206 PS1, Line 206: uint64_t Rbp; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@207 PS1, Line 207: uint64_t Rdx; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@207 PS1, Line 207: uint64_t Rdx; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@207 PS1, Line 207: uint64_t Rdx; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@208 PS1, Line 208: uint64_t Rcx; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@208 PS1, Line 208: uint64_t Rcx; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@208 PS1, Line 208: uint64_t Rcx; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@209 PS1, Line 209: uint64_t Rbx; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@209 PS1, Line 209: uint64_t Rbx; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@209 PS1, Line 209: uint64_t Rbx; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@210 PS1, Line 210: uint64_t Rax; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@210 PS1, Line 210: uint64_t Rax; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@210 PS1, Line 210: uint64_t Rax; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@211 PS1, Line 211: uint64_t Cr8; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@211 PS1, Line 211: uint64_t Cr8; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@211 PS1, Line 211: uint64_t Cr8; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@212 PS1, Line 212: uint64_t Cr3; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@212 PS1, Line 212: uint64_t Cr3; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@212 PS1, Line 212: uint64_t Cr3; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@213 PS1, Line 213: uint64_t Cr2; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@213 PS1, Line 213: uint64_t Cr2; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@213 PS1, Line 213: uint64_t Cr2; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@214 PS1, Line 214: uint64_t Cr0; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@214 PS1, Line 214: uint64_t Cr0; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@214 PS1, Line 214: uint64_t Cr0; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@215 PS1, Line 215: uint64_t VmcsExitInstructionInfo; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@215 PS1, Line 215: uint64_t VmcsExitInstructionInfo; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@215 PS1, Line 215: uint64_t VmcsExitInstructionInfo; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@216 PS1, Line 216: uint64_t VmcsExitInstructionLength; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@216 PS1, Line 216: uint64_t VmcsExitInstructionLength; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@216 PS1, Line 216: uint64_t VmcsExitInstructionLength; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@217 PS1, Line 217: uint64_t VmcsExitQualification; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@217 PS1, Line 217: uint64_t VmcsExitQualification; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@217 PS1, Line 217: uint64_t VmcsExitQualification; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@218 PS1, Line 218: uint64_t ErrorCode; // TXT_SMM_PROTECTION_EXCEPTION_TYPE code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@218 PS1, Line 218: uint64_t ErrorCode; // TXT_SMM_PROTECTION_EXCEPTION_TYPE please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@218 PS1, Line 218: uint64_t ErrorCode; // TXT_SMM_PROTECTION_EXCEPTION_TYPE please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@219 PS1, Line 219: uint64_t Rip; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@219 PS1, Line 219: uint64_t Rip; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@219 PS1, Line 219: uint64_t Rip; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@220 PS1, Line 220: uint64_t Cs; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@220 PS1, Line 220: uint64_t Cs; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@220 PS1, Line 220: uint64_t Cs; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@221 PS1, Line 221: uint64_t Rflags; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@221 PS1, Line 221: uint64_t Rflags; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@221 PS1, Line 221: uint64_t Rflags; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@222 PS1, Line 222: uint64_t Rsp; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@222 PS1, Line 222: uint64_t Rsp; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@222 PS1, Line 222: uint64_t Rsp; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@223 PS1, Line 223: uint64_t Ss; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@223 PS1, Line 223: uint64_t Ss; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@223 PS1, Line 223: uint64_t Ss; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@227 PS1, Line 227: STM_PROTECTION_EXCEPTION_STACK_FRAME_IA32 *Ia32StackFrame; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@227 PS1, Line 227: STM_PROTECTION_EXCEPTION_STACK_FRAME_IA32 *Ia32StackFrame; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@227 PS1, Line 227: STM_PROTECTION_EXCEPTION_STACK_FRAME_IA32 *Ia32StackFrame; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@228 PS1, Line 228: STM_PROTECTION_EXCEPTION_STACK_FRAME_X64 *X64StackFrame; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@228 PS1, Line 228: STM_PROTECTION_EXCEPTION_STACK_FRAME_X64 *X64StackFrame; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@228 PS1, Line 228: STM_PROTECTION_EXCEPTION_STACK_FRAME_X64 *X64StackFrame; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@234 PS1, Line 234: uint8_t Reserved1[0x1d0]; // fc00h code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@234 PS1, Line 234: uint8_t Reserved1[0x1d0]; // fc00h please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@234 PS1, Line 234: uint8_t Reserved1[0x1d0]; // fc00h please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@235 PS1, Line 235: uint32_t GdtBaseHiDword; // fdd0h : NO code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@235 PS1, Line 235: uint32_t GdtBaseHiDword; // fdd0h : NO please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@235 PS1, Line 235: uint32_t GdtBaseHiDword; // fdd0h : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@236 PS1, Line 236: uint32_t LdtBaseHiDword; // fdd4h : NO code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@236 PS1, Line 236: uint32_t LdtBaseHiDword; // fdd4h : NO please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@236 PS1, Line 236: uint32_t LdtBaseHiDword; // fdd4h : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@237 PS1, Line 237: uint32_t IdtBaseHiDword; // fdd8h : NO code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@237 PS1, Line 237: uint32_t IdtBaseHiDword; // fdd8h : NO please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@237 PS1, Line 237: uint32_t IdtBaseHiDword; // fdd8h : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@238 PS1, Line 238: uint8_t Reserved2[0x4]; // fddch code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@238 PS1, Line 238: uint8_t Reserved2[0x4]; // fddch please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@238 PS1, Line 238: uint8_t Reserved2[0x4]; // fddch please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@239 PS1, Line 239: uint64_t IoRdi; // fde0h : NO code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@239 PS1, Line 239: uint64_t IoRdi; // fde0h : NO please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@239 PS1, Line 239: uint64_t IoRdi; // fde0h : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@240 PS1, Line 240: // - restricted code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@241 PS1, Line 241: uint64_t IoEip; // fde8h : YES code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@241 PS1, Line 241: uint64_t IoEip; // fde8h : YES please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@241 PS1, Line 241: uint64_t IoEip; // fde8h : YES please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@242 PS1, Line 242: uint64_t IoRcx; // fdf0h : NO code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@242 PS1, Line 242: uint64_t IoRcx; // fdf0h : NO please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@242 PS1, Line 242: uint64_t IoRcx; // fdf0h : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@243 PS1, Line 243: // - restricted code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@244 PS1, Line 244: uint64_t IoRsi; // fdf8h : NO code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@244 PS1, Line 244: uint64_t IoRsi; // fdf8h : NO please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@244 PS1, Line 244: uint64_t IoRsi; // fdf8h : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@245 PS1, Line 245: // - restricted code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@246 PS1, Line 246: uint8_t Reserved3[0x40]; // fe00h code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@246 PS1, Line 246: uint8_t Reserved3[0x40]; // fe00h please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@246 PS1, Line 246: uint8_t Reserved3[0x40]; // fe00h please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@247 PS1, Line 247: uint32_t Cr4; // fe40h : NO code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@247 PS1, Line 247: uint32_t Cr4; // fe40h : NO please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@247 PS1, Line 247: uint32_t Cr4; // fe40h : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@248 PS1, Line 248: uint8_t Reserved4[0x48]; // fe44h code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@248 PS1, Line 248: uint8_t Reserved4[0x48]; // fe44h please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@248 PS1, Line 248: uint8_t Reserved4[0x48]; // fe44h please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@249 PS1, Line 249: uint32_t GdtBaseLoDword; // fe8ch : NO code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@249 PS1, Line 249: uint32_t GdtBaseLoDword; // fe8ch : NO please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@249 PS1, Line 249: uint32_t GdtBaseLoDword; // fe8ch : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@250 PS1, Line 250: uint32_t GdtLimit; // fe90h : NO code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@250 PS1, Line 250: uint32_t GdtLimit; // fe90h : NO please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@250 PS1, Line 250: uint32_t GdtLimit; // fe90h : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@251 PS1, Line 251: // - RESTRICTED code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@252 PS1, Line 252: uint32_t IdtBaseLoDword; // fe94h : NO code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@252 PS1, Line 252: uint32_t IdtBaseLoDword; // fe94h : NO please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@252 PS1, Line 252: uint32_t IdtBaseLoDword; // fe94h : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@253 PS1, Line 253: uint32_t IdtLimit; // fe98h : NO trailing whitespace
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@253 PS1, Line 253: uint32_t IdtLimit; // fe98h : NO code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@253 PS1, Line 253: uint32_t IdtLimit; // fe98h : NO please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@253 PS1, Line 253: uint32_t IdtLimit; // fe98h : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@254 PS1, Line 254: // - RESTRICTED code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@255 PS1, Line 255: uint32_t LdtBaseLoDword; // fe9ch : NO code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@255 PS1, Line 255: uint32_t LdtBaseLoDword; // fe9ch : NO please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@255 PS1, Line 255: uint32_t LdtBaseLoDword; // fe9ch : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@256 PS1, Line 256: uint32_t LdtLimit; // fea0h : NO code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@256 PS1, Line 256: uint32_t LdtLimit; // fea0h : NO please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@256 PS1, Line 256: uint32_t LdtLimit; // fea0h : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@257 PS1, Line 257: // - RESTRICTED code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@258 PS1, Line 258: uint32_t LdtInfo; // fea4h : NO trailing whitespace
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@258 PS1, Line 258: uint32_t LdtInfo; // fea4h : NO code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@258 PS1, Line 258: uint32_t LdtInfo; // fea4h : NO please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@258 PS1, Line 258: uint32_t LdtInfo; // fea4h : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@259 PS1, Line 259: // - RESTRICTED code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@260 PS1, Line 260: uint8_t Reserved5[0x30]; // fea8h code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@260 PS1, Line 260: uint8_t Reserved5[0x30]; // fea8h please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@260 PS1, Line 260: uint8_t Reserved5[0x30]; // fea8h please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@261 PS1, Line 261: uint64_t Eptp; // fed8h : NO code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@261 PS1, Line 261: uint64_t Eptp; // fed8h : NO please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@261 PS1, Line 261: uint64_t Eptp; // fed8h : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@262 PS1, Line 262: uint32_t EnabledEPT; // fee0h : NO code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@262 PS1, Line 262: uint32_t EnabledEPT; // fee0h : NO please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@262 PS1, Line 262: uint32_t EnabledEPT; // fee0h : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@263 PS1, Line 263: uint8_t Reserved6[0x14]; // fee4h code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@263 PS1, Line 263: uint8_t Reserved6[0x14]; // fee4h please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@263 PS1, Line 263: uint8_t Reserved6[0x14]; // fee4h please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@264 PS1, Line 264: uint32_t Smbase; // fef8h : YES code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@264 PS1, Line 264: uint32_t Smbase; // fef8h : YES please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@264 PS1, Line 264: uint32_t Smbase; // fef8h : YES please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@265 PS1, Line 265: // - NO for STM code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@266 PS1, Line 266: uint32_t SMMRevId; // fefch : NO code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@266 PS1, Line 266: uint32_t SMMRevId; // fefch : NO please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@266 PS1, Line 266: uint32_t SMMRevId; // fefch : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@267 PS1, Line 267: uint16_t IORestart; // ff00h : YES code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@267 PS1, Line 267: uint16_t IORestart; // ff00h : YES please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@267 PS1, Line 267: uint16_t IORestart; // ff00h : YES please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@268 PS1, Line 268: uint16_t AutoHALTRestart; // ff02h : YES code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@268 PS1, Line 268: uint16_t AutoHALTRestart; // ff02h : YES please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@268 PS1, Line 268: uint16_t AutoHALTRestart; // ff02h : YES please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@269 PS1, Line 269: uint8_t Reserved7[0x18]; // ff04h code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@269 PS1, Line 269: uint8_t Reserved7[0x18]; // ff04h please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@269 PS1, Line 269: uint8_t Reserved7[0x18]; // ff04h please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@270 PS1, Line 270: uint64_t R15; // ff1ch : YES code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@270 PS1, Line 270: uint64_t R15; // ff1ch : YES please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@270 PS1, Line 270: uint64_t R15; // ff1ch : YES please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@271 PS1, Line 271: uint64_t R14; // ff24h : YES code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@271 PS1, Line 271: uint64_t R14; // ff24h : YES please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@271 PS1, Line 271: uint64_t R14; // ff24h : YES please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@272 PS1, Line 272: uint64_t R13; // ff2ch : YES code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@272 PS1, Line 272: uint64_t R13; // ff2ch : YES please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@272 PS1, Line 272: uint64_t R13; // ff2ch : YES please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@273 PS1, Line 273: uint64_t R12; // ff34h : YES code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@273 PS1, Line 273: uint64_t R12; // ff34h : YES please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@273 PS1, Line 273: uint64_t R12; // ff34h : YES please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@274 PS1, Line 274: uint64_t R11; // ff3ch : YES code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@274 PS1, Line 274: uint64_t R11; // ff3ch : YES please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@274 PS1, Line 274: uint64_t R11; // ff3ch : YES please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@275 PS1, Line 275: uint64_t R10; // ff44h : YES code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@275 PS1, Line 275: uint64_t R10; // ff44h : YES please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@275 PS1, Line 275: uint64_t R10; // ff44h : YES please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@276 PS1, Line 276: uint64_t R9; // ff4ch : YES code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@276 PS1, Line 276: uint64_t R9; // ff4ch : YES please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@276 PS1, Line 276: uint64_t R9; // ff4ch : YES please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@277 PS1, Line 277: uint64_t R8; // ff54h : YES code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@277 PS1, Line 277: uint64_t R8; // ff54h : YES please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@277 PS1, Line 277: uint64_t R8; // ff54h : YES please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@278 PS1, Line 278: uint64_t Rax; // ff5ch : YES code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@278 PS1, Line 278: uint64_t Rax; // ff5ch : YES please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@278 PS1, Line 278: uint64_t Rax; // ff5ch : YES please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@279 PS1, Line 279: uint64_t Rcx; // ff64h : YES code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@279 PS1, Line 279: uint64_t Rcx; // ff64h : YES please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@279 PS1, Line 279: uint64_t Rcx; // ff64h : YES please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@280 PS1, Line 280: uint64_t Rdx; // ff6ch : YES code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@280 PS1, Line 280: uint64_t Rdx; // ff6ch : YES please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@280 PS1, Line 280: uint64_t Rdx; // ff6ch : YES please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@281 PS1, Line 281: uint64_t Rbx; // ff74h : YES code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@281 PS1, Line 281: uint64_t Rbx; // ff74h : YES please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@281 PS1, Line 281: uint64_t Rbx; // ff74h : YES please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@282 PS1, Line 282: uint64_t Rsp; // ff7ch : YES code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@282 PS1, Line 282: uint64_t Rsp; // ff7ch : YES please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@282 PS1, Line 282: uint64_t Rsp; // ff7ch : YES please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@283 PS1, Line 283: uint64_t Rbp; // ff84h : YES code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@283 PS1, Line 283: uint64_t Rbp; // ff84h : YES please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@283 PS1, Line 283: uint64_t Rbp; // ff84h : YES please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@284 PS1, Line 284: uint64_t Rsi; // ff8ch : YES code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@284 PS1, Line 284: uint64_t Rsi; // ff8ch : YES please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@284 PS1, Line 284: uint64_t Rsi; // ff8ch : YES please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@285 PS1, Line 285: uint64_t Rdi; // ff94h : YES code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@285 PS1, Line 285: uint64_t Rdi; // ff94h : YES please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@285 PS1, Line 285: uint64_t Rdi; // ff94h : YES please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@286 PS1, Line 286: uint64_t IOMemAddr; // ff9ch : NO code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@286 PS1, Line 286: uint64_t IOMemAddr; // ff9ch : NO please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@286 PS1, Line 286: uint64_t IOMemAddr; // ff9ch : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@287 PS1, Line 287: uint32_t IOMisc; // ffa4h : NO code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@287 PS1, Line 287: uint32_t IOMisc; // ffa4h : NO please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@287 PS1, Line 287: uint32_t IOMisc; // ffa4h : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@288 PS1, Line 288: uint32_t Es; // ffa8h : NO code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@288 PS1, Line 288: uint32_t Es; // ffa8h : NO please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@288 PS1, Line 288: uint32_t Es; // ffa8h : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@289 PS1, Line 289: uint32_t Cs; // ffach : NO code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@289 PS1, Line 289: uint32_t Cs; // ffach : NO please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@289 PS1, Line 289: uint32_t Cs; // ffach : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@290 PS1, Line 290: uint32_t Ss; // ffb0h : NO code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@290 PS1, Line 290: uint32_t Ss; // ffb0h : NO please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@290 PS1, Line 290: uint32_t Ss; // ffb0h : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@291 PS1, Line 291: uint32_t Ds; // ffb4h : NO code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@291 PS1, Line 291: uint32_t Ds; // ffb4h : NO please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@291 PS1, Line 291: uint32_t Ds; // ffb4h : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@292 PS1, Line 292: uint32_t Fs; // ffb8h : NO code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@292 PS1, Line 292: uint32_t Fs; // ffb8h : NO please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@292 PS1, Line 292: uint32_t Fs; // ffb8h : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@293 PS1, Line 293: uint32_t Gs; // ffbch : NO code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@293 PS1, Line 293: uint32_t Gs; // ffbch : NO please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@293 PS1, Line 293: uint32_t Gs; // ffbch : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@294 PS1, Line 294: uint32_t Ldtr; // ffc0h : NO code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@294 PS1, Line 294: uint32_t Ldtr; // ffc0h : NO please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@294 PS1, Line 294: uint32_t Ldtr; // ffc0h : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@295 PS1, Line 295: uint32_t Tr; // ffc4h : NO code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@295 PS1, Line 295: uint32_t Tr; // ffc4h : NO please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@295 PS1, Line 295: uint32_t Tr; // ffc4h : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@296 PS1, Line 296: uint64_t Dr7; // ffc8h : NO code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@296 PS1, Line 296: uint64_t Dr7; // ffc8h : NO please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@296 PS1, Line 296: uint64_t Dr7; // ffc8h : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@297 PS1, Line 297: uint64_t Dr6; // ffd0h : NO code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@297 PS1, Line 297: uint64_t Dr6; // ffd0h : NO please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@297 PS1, Line 297: uint64_t Dr6; // ffd0h : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@298 PS1, Line 298: uint64_t Rip; // ffd8h : YES code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@298 PS1, Line 298: uint64_t Rip; // ffd8h : YES please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@298 PS1, Line 298: uint64_t Rip; // ffd8h : YES please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@299 PS1, Line 299: uint64_t Ia32Efer; // ffe0h : YES code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@299 PS1, Line 299: uint64_t Ia32Efer; // ffe0h : YES please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@299 PS1, Line 299: uint64_t Ia32Efer; // ffe0h : YES please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@301 PS1, Line 301: uint64_t Rflags; // ffe8h : YES code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@301 PS1, Line 301: uint64_t Rflags; // ffe8h : YES please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@301 PS1, Line 301: uint64_t Rflags; // ffe8h : YES please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@302 PS1, Line 302: uint64_t Cr3; // fff0h : NO code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@302 PS1, Line 302: uint64_t Cr3; // fff0h : NO please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@302 PS1, Line 302: uint64_t Cr3; // fff0h : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@303 PS1, Line 303: uint64_t Cr0; // fff8h : NO code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@303 PS1, Line 303: uint64_t Cr0; // fff8h : NO please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@303 PS1, Line 303: uint64_t Cr0; // fff8h : NO please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@312 PS1, Line 312: uint64_t VirtualAddress; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@312 PS1, Line 312: uint64_t VirtualAddress; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@312 PS1, Line 312: uint64_t VirtualAddress; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@313 PS1, Line 313: uint32_t PageCount; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@313 PS1, Line 313: uint32_t PageCount; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@313 PS1, Line 313: uint32_t PageCount; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@314 PS1, Line 314: uint32_t PatCacheType; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@314 PS1, Line 314: uint32_t PatCacheType; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@314 PS1, Line 314: uint32_t PatCacheType; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@325 PS1, Line 325: uint64_t VirtualAddress; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@325 PS1, Line 325: uint64_t VirtualAddress; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@325 PS1, Line 325: uint64_t VirtualAddress; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@326 PS1, Line 326: uint32_t Length; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@326 PS1, Line 326: uint32_t Length; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@326 PS1, Line 326: uint32_t Length; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@330 PS1, Line 330: uint64_t InterruptedGuestVirtualAddress; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@330 PS1, Line 330: uint64_t InterruptedGuestVirtualAddress; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@330 PS1, Line 330: uint64_t InterruptedGuestVirtualAddress; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@331 PS1, Line 331: uint32_t Length; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@331 PS1, Line 331: uint32_t Length; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@331 PS1, Line 331: uint32_t Length; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@332 PS1, Line 332: uint64_t InterruptedCr3; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@332 PS1, Line 332: uint64_t InterruptedCr3; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@332 PS1, Line 332: uint64_t InterruptedCr3; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@333 PS1, Line 333: uint64_t InterruptedEptp; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@333 PS1, Line 333: uint64_t InterruptedEptp; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@333 PS1, Line 333: uint64_t InterruptedEptp; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@334 PS1, Line 334: uint32_t MapToSmmGuest:2; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@334 PS1, Line 334: uint32_t MapToSmmGuest:2; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@334 PS1, Line 334: uint32_t MapToSmmGuest:2; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@335 PS1, Line 335: uint32_t InterruptedCr4Pae:1; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@335 PS1, Line 335: uint32_t InterruptedCr4Pae:1; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@335 PS1, Line 335: uint32_t InterruptedCr4Pae:1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@336 PS1, Line 336: uint32_t InterruptedCr4Pse:1; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@336 PS1, Line 336: uint32_t InterruptedCr4Pse:1; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@336 PS1, Line 336: uint32_t InterruptedCr4Pse:1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@337 PS1, Line 337: uint32_t InterruptedIa32eMode:1; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@337 PS1, Line 337: uint32_t InterruptedIa32eMode:1; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@337 PS1, Line 337: uint32_t InterruptedIa32eMode:1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@338 PS1, Line 338: uint32_t Reserved1:27; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@338 PS1, Line 338: uint32_t Reserved1:27; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@338 PS1, Line 338: uint32_t Reserved1:27; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@339 PS1, Line 339: uint32_t Reserved2; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@339 PS1, Line 339: uint32_t Reserved2; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@339 PS1, Line 339: uint32_t Reserved2; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@340 PS1, Line 340: uint64_t PhysicalAddress; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@340 PS1, Line 340: uint64_t PhysicalAddress; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@340 PS1, Line 340: uint64_t PhysicalAddress; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@341 PS1, Line 341: uint64_t SmmGuestVirtualAddress; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@341 PS1, Line 341: uint64_t SmmGuestVirtualAddress; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@341 PS1, Line 341: uint64_t SmmGuestVirtualAddress; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@364 PS1, Line 364: uint16_t ReturnStatus:1; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@364 PS1, Line 364: uint16_t ReturnStatus:1; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@364 PS1, Line 364: uint16_t ReturnStatus:1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@365 PS1, Line 365: uint16_t Reserved:14; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@365 PS1, Line 365: uint16_t Reserved:14; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@365 PS1, Line 365: uint16_t Reserved:14; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@366 PS1, Line 366: uint16_t IgnoreResource:1; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@366 PS1, Line 366: uint16_t IgnoreResource:1; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@366 PS1, Line 366: uint16_t IgnoreResource:1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@505 PS1, Line 505: //#define DOMAIN_INTEGRITY_PROT_OUT (DOMAIN_INTEGRITY | DOMAIN_DISALLOWED_IO_IN) line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@507 PS1, Line 507: //#define DOMAIN_FULLY_PROT_IN (DOMAIN_CONFIDENTIALITY | DOMAIN_INTEGRITY | DOMAIN_DISALLOWED_IO_OUT) line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@508 PS1, Line 508: //#define DOMAIN_FULLY_PROT_OUT (DOMAIN_CONFIDENTIALITY | DOMAIN_INTEGRITY | DOMAIN_DISALLOWED_IO_IN) line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@509 PS1, Line 509: #define DOMAIN_FULLY_PROT (DOMAIN_CONFIDENTIALITY | DOMAIN_INTEGRITY | DOMAIN_DISALLOWED_IO_IN | DOMAIN_DISALLOWED_IO_OUT) line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmApi.h@751 PS1, Line 751: #pragma pack (pop) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformRe... File src/security/intel/stm/StmPlatformResource.h:
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformRe... PS1, Line 35: #define SMRR_PHYSMASK_MSR 0x1F3 trailing whitespace
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformRe... File src/security/intel/stm/StmPlatformResource.c:
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformRe... PS1, Line 50: {MEM_RANGE, sizeof (STM_RSC_MEM_DESC)}, space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformRe... PS1, Line 59: {MEM_RANGE, sizeof (STM_RSC_MEM_DESC)}, space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformRe... PS1, Line 68: {IO_RANGE, sizeof (STM_RSC_IO_DESC)}, space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformRe... PS1, Line 77: {MMIO_RANGE, sizeof (STM_RSC_MMIO_DESC)}, space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformRe... PS1, Line 86: {MMIO_RANGE, sizeof (STM_RSC_MMIO_DESC)}, space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformRe... PS1, Line 95: {TRAPPED_IO_RANGE, sizeof (STM_RSC_TRAPPED_IO_DESC)}, space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformRe... PS1, Line 103: {END_OF_RESOURCES, sizeof (STM_RSC_END)}, space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformRe... PS1, Line 114: {PCI_CFG_RANGE, sizeof (STM_RSC_PCI_CFG_DESC)}, space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformRe... PS1, Line 115: RDWR_ACCS, 0, code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformRe... PS1, Line 115: RDWR_ACCS, 0, please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformRe... PS1, Line 115: RDWR_ACCS, 0, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformRe... PS1, Line 121: {1, 1, sizeof(STM_PCI_DEVICE_PATH_NODE), LPC_FUNCTION, LPC_DEVICE}, line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformRe... PS1, Line 121: {1, 1, sizeof(STM_PCI_DEVICE_PATH_NODE), LPC_FUNCTION, LPC_DEVICE}, code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformRe... PS1, Line 121: {1, 1, sizeof(STM_PCI_DEVICE_PATH_NODE), LPC_FUNCTION, LPC_DEVICE}, please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformRe... PS1, Line 121: {1, 1, sizeof(STM_PCI_DEVICE_PATH_NODE), LPC_FUNCTION, LPC_DEVICE}, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformRe... PS1, Line 129: {MACHINE_SPECIFIC_REG, sizeof (STM_RSC_MSR_DESC)}, space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformRe... PS1, Line 142: // Index Read Write // MASK64 means need access, MASK0 means no need access. line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformRe... PS1, Line 163: mTsegBase = MsrRead.lo & 0xFFFFF000; code indent should use tabs where possible
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformRe... PS1, Line 163: mTsegBase = MsrRead.lo & 0xFFFFF000; please, no space before tabs
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformRe... PS1, Line 163: mTsegBase = MsrRead.lo & 0xFFFFF000; please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformRe... PS1, Line 164: trailing whitespace
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformRe... PS1, Line 164: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformRe... PS1, Line 165: //mTsegSize = (uint32_t)(~((uint32_t)rdmsr(SMRR_PHYSMASK_MSR) & 0xFFFFF000) + 1); line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformRe... PS1, Line 166: trailing whitespace
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformRe... PS1, Line 166: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformRe... PS1, Line 181: // trailing whitespace
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformRe... PS1, Line 204: trailing whitespace
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformRe... PS1, Line 204: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformRe... PS1, Line 209: // be corrected. trailing whitespace
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformRe... PS1, Line 219: FixupPciexResource (); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformRe... PS1, Line 237: for (Index = 0; Index < sizeof(MsrTable)/sizeof(MsrTable[0]); Index ++) { line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformRe... PS1, Line 237: for (Index = 0; Index < sizeof(MsrTable)/sizeof(MsrTable[0]); Index ++) { Prefer ARRAY_SIZE(MsrTable)
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformRe... PS1, Line 237: for (Index = 0; Index < sizeof(MsrTable)/sizeof(MsrTable[0]); Index ++) { space prohibited before that '++' (ctx:WxB)
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformRe... PS1, Line 238: trailing whitespace
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformRe... PS1, Line 238: please, no spaces at the start of a line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformRe... PS1, Line 243: Status = AddPiResource ((void *) &RscMsrTpl, 1); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformSm... File src/security/intel/stm/StmPlatformSmm.c:
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformSm... PS1, Line 52: StmBufferSize = CONFIG_MSEG_SIZE; trailing whitespace
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformSm... PS1, Line 57: StmImageSize = cbfs_boot_load_file("stm.bin", MsegBase, StmBufferSize, CBFS_TYPE_RAW); line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformSm... PS1, Line 58: printk(BIOS_DEBUG, "STM loaded into mseg: 0x%08x size: %u \n", (uint32_t) MsegBase, StmImageSize); /* status is number of bytes loaded */ line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformSm... PS1, Line 58: printk(BIOS_DEBUG, "STM loaded into mseg: 0x%08x size: %u \n", (uint32_t) MsegBase, StmImageSize); /* status is number of bytes loaded */ unnecessary whitespace before a quoted newline
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformSm... PS1, Line 64: StmGen4GPageTableX64 ((uint32_t)MsegBase + StmHeader->HwStmHdr.Cr3Offset); line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformSm... PS1, Line 64: StmGen4GPageTableX64 ((uint32_t)MsegBase + StmHeader->HwStmHdr.Cr3Offset); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformSm... PS1, Line 72: printk(BIOS_DEBUG, "STM Header - StaticImageSize: %d Cr3Location: 0x%08x \n", unnecessary whitespace before a quoted newline
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformSm... PS1, Line 82: { open brace '{' following struct go on the same line
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformSm... PS1, Line 88: void ReadGdtr( struct descriptor *gdtr); space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformSm... PS1, Line 90: void ReadGdtr( struct descriptor *gdtr) space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformSm... PS1, Line 98: void SetupSmmDescriptor(void *smbase, int32_t state_size, int32_t apic_id, int32_t entry32_off) line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformSm... PS1, Line 102: TXT_PROCESSOR_SMM_DESCRIPTOR * Psd; "foo * bar" should be "foo *bar"
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformSm... PS1, Line 105: trailing whitespace
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformSm... PS1, Line 106: printk(BIOS_DEBUG, "Setting up Smm Descriptor - Smbase: %p Psd: %p\n", smbase, Psd); line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformSm... PS1, Line 108: memset(Psd, 0, sizeof(TXT_PROCESSOR_SMM_DESCRIPTOR)); trailing whitespace
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformSm... PS1, Line 113: Psd->SmmSmiHandlerRip = (uint64_t)((uint32_t)smbase + SMM_ENTRY_OFFSET + entry32_off); line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformSm... PS1, Line 117: Psd->BiosHwResourceRequirementsPtr = (uint64_t)((uint32_t)GetStmResource()); line over 80 characters
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/StmPlatformSm... PS1, Line 127: Psd->SmmGdtSize = Gdtr.limit + 1; // the stm will subtract, so need to compensate line over 80 characters