Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35312 )
Change subject: soc/intel/common/block/sgx: Fix crash in MP init
......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35312/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35312/1//COMMIT_MSG@12
PS1, Line 12: I could not find any relation between those two in any datasheet.
likly a bug in coreboot or 3rdparty blobs
Done
https://review.coreboot.org/c/coreboot/+/35312/1//COMMIT_MSG@14
PS1, Line 14: To fully migitate L1TF or E2E attacks, hyperthreading should be disabled
I guess this can be made runtime detectable, as not all CPUs have HT and SGX enabled.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35312
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7102da028a449c60ca700b3f9ccda9017aa6d6b5
Gerrit-Change-Number: 35312
Gerrit-PatchSet: 7
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Michael Niewöhner
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 26 Sep 2019 10:49:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-MessageType: comment