Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40721 )
Change subject: nb/intel/sandybridge/raminit: Fix ECC scrub ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40721/4/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit_common.c:
https://review.coreboot.org/c/coreboot/+/40721/4/src/northbridge/intel/sandy... PS4, Line 2962: slotrank & 0xC
It took me a while to understand "slotrank", but it's just the combination of a slot and a rank.
Oh, I mixed it with the rankmap. slotrank >> 1 was correct.
https://review.coreboot.org/c/coreboot/+/40721/4/src/northbridge/intel/sandy... PS4, Line 2965: * Bank bits are located at bit 13:15 in physical memory map : * Rowbits start at bit 20 in physical memory map
What purpose do these comments serve? Even if that is the […]
They help understand what's wrong by observing the patterns in the ecc scrub test. Should it be moved to the testing code?
https://review.coreboot.org/c/coreboot/+/40721/4/src/northbridge/intel/sandy... PS4, Line 2994: (bank << 20)
The 0x400 (bit 10) make it a PREA (precharge all banks), so the bank address is not needed. […]
Probably copy&paste error from the other subseq commands. None of them specifies a bank. Will do test without that bit.