Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35960 )
Change subject: trogdor: libpayload uart/serial driver support ......................................................................
Patch Set 21:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35960/21//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35960/21//COMMIT_MSG@7 PS21, Line 7: trogdor: libpayload uart/serial driver support Please make it a statement, and prefix with libpayload:
libpayload: Add UART/serial driver for trogdor
Even:
libpayload: Add Qualcomm QUPV3 UART/serial driver
Tested-on: trogdor
https://review.coreboot.org/c/coreboot/+/35960/21/payloads/libpayload/driver... File payloads/libpayload/drivers/serial/qcom_qupv3_serial.c:
https://review.coreboot.org/c/coreboot/+/35960/21/payloads/libpayload/driver... PS21, Line 2: . Can be removed.
https://review.coreboot.org/c/coreboot/+/35960/21/payloads/libpayload/driver... PS21, Line 287: GENI_STATUS_M_GENI_CMD_ACTIVE_MASK) Fits on one line now.