[coreboot-gerrit] Change in ...coreboot[master]: soc/intel: Provide SPD manufacturer ID and module type to SMBIOS

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33379 )

Change subject: soc/intel: Provide SPD manufacturer ID and module type to SMBIOS
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/33379/1/src/soc/intel/common/smbios.c 
File src/soc/intel/common/smbios.c:

https://review.coreboot.org/#/c/33379/1/src/soc/intel/common/smbios.c@31 
PS1, Line 31: mod_type
You use ddr3 defines to convert ddr4 mod_type to DDR2?
That looks very broken. Please fix the SMBIOS/cbmem interface instead.