Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37582 )
Change subject: intel/fsp2_0: Make FSP_USE_REPO a SoC opt-in
......................................................................
Patch Set 15:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37582/15/src/soc/intel/Kconfig
File src/soc/intel/Kconfig:
https://review.coreboot.org/c/coreboot/+/37582/15/src/soc/intel/Kconfig@42
PS15, Line 42: HAVE_INTEL_FSP_REPO
What do you think about having a negative config "FSP_REPO_NOT_PUBLIC"? Then, only the platforms tha […]
I don't really like negative Kconfig symbols (they don't play nice with Kconfig's additive nature). However, it would not be a problem here, so I don't have a strong opinion on the matter.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37582
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I68ae373ce591f06073064aa75aac32ceca8fa1cc
Gerrit-Change-Number: 37582
Gerrit-PatchSet: 15
Gerrit-Owner: Mimoja
coreboot@mimoja.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Mimoja
coreboot@mimoja.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 24 Mar 2020 09:59:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment