Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36612 )
Change subject: arch/x86: Link NO_XIP_EARLY_STAGES like other stages ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36612/1/src/arch/x86/assembly_entry... File src/arch/x86/assembly_entry.S:
https://review.coreboot.org/c/coreboot/+/36612/1/src/arch/x86/assembly_entry... PS1, Line 36: #if !ENV_STAGE_HAS_DATA_SECTION
That's assuming we have memlen set correctly in the case you are describing. I'm pretty sure we don't, but there are some funny combinations to deal with. What have you done to ensure the assertions are held you are implying here?
You mean that the memlen that is currently hardcoded to 1M and should be checked if it fits in CAR? That should be done regardless of this patch?