Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44037 )
Change subject: sconfig: Allow chipset to provide a base devicetree ......................................................................
Patch Set 10:
(5 comments)
https://review.coreboot.org/c/coreboot/+/44037/9/Makefile.inc File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/44037/9/Makefile.inc@16 PS9, Line 16: CONFIG_CHIPSET_DEVICETREE
Shouldn't this config option be added to src/Kconfig in this CL?
Done
https://review.coreboot.org/c/coreboot/+/44037/9/Makefile.inc@607 PS9, Line 607: $(src)/
The expectation is that the chipset devicetree path should be relative to src/ directory. […]
Done
https://review.coreboot.org/c/coreboot/+/44037/9/util/sconfig/main.c File util/sconfig/main.c:
https://review.coreboot.org/c/coreboot/+/44037/9/util/sconfig/main.c@1763 PS9, Line 1763: parse_override_devicetree
the chipset device tree doesn't exist for most soc (or even non-soc for the older stuff using nort […]
Talked to Duncan and Tim offline. Let's address these comments in a follow-up CL to make it more generic.
https://review.coreboot.org/c/coreboot/+/44037/10/util/sconfig/main.c File util/sconfig/main.c:
https://review.coreboot.org/c/coreboot/+/44037/10/util/sconfig/main.c@1598 PS10, Line 1598: root_parent No, this change is not correct. We need to lookup the alias in the base_root_dev or the primary tree. root_parent at this point would be pointing to the override tree.
https://review.coreboot.org/c/coreboot/+/44037/9/util/sconfig/sconfig.h File util/sconfig/sconfig.h:
https://review.coreboot.org/c/coreboot/+/44037/9/util/sconfig/sconfig.h@136 PS9, Line 136: devnum
It would be helpful to have a comment indicating what this really is.
Done