Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41891 )
Change subject: dptf: Add support for Fan and TSR options
......................................................................
Patch Set 10:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41891/10/src/drivers/intel/dptf/chi...
File src/drivers/intel/dptf/chip.h:
https://review.coreboot.org/c/coreboot/+/41891/10/src/drivers/intel/dptf/chi...
PS10, Line 21: struct
add a comment at the top that these are optional. (I think?)
https://review.coreboot.org/c/coreboot/+/41891/10/src/drivers/intel/dptf/chi...
PS10, Line 35: hysteresis
I see the function for writing this, but not the call that passes this config variable (if defined? since the EC can write it too)
https://review.coreboot.org/c/coreboot/+/41891/10/src/drivers/intel/dptf/chi...
PS10, Line 36: desc
add a comment for this option about defining the names of the temp sensors.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41891
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I42d789d877da28c163e394d7de5fb1ff339264eb
Gerrit-Change-Number: 41891
Gerrit-PatchSet: 10
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 22 Jun 2020 22:16:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment