Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/54358 )
Change subject: mainboard: Use decimal for `device domain 0x0 on` ......................................................................
mainboard: Use decimal for `device domain 0x0 on`
Most boards use `device domain 0 on` with zero written in decimal. For the sake of consistency, update the remaining boards to follow suit.
Change-Id: I6e2f0a19d57cfe6fc4e4ac4d14310133ad6b01d8 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/54358 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M src/mainboard/apple/macbookair4_2/devicetree.cb M src/mainboard/asrock/b75pro3-m/devicetree.cb M src/mainboard/asus/h61m-cs/devicetree.cb M src/mainboard/asus/p8h61-m_pro/devicetree.cb M src/mainboard/asus/p8z77-m_pro/devicetree.cb M src/mainboard/compulab/intense_pc/devicetree.cb M src/mainboard/dell/optiplex_9010/devicetree.cb M src/mainboard/hp/compaq_8200_elite_sff/devicetree.cb M src/mainboard/hp/folio_9480m/devicetree.cb M src/mainboard/hp/snb_ivb_laptops/devicetree.cb M src/mainboard/hp/snb_ivb_laptops/variants/2570p/overridetree.cb M src/mainboard/hp/snb_ivb_laptops/variants/2760p/overridetree.cb M src/mainboard/hp/snb_ivb_laptops/variants/8460p/overridetree.cb M src/mainboard/hp/snb_ivb_laptops/variants/8470p/overridetree.cb M src/mainboard/hp/snb_ivb_laptops/variants/8770w/overridetree.cb M src/mainboard/hp/snb_ivb_laptops/variants/folio_9470m/overridetree.cb M src/mainboard/hp/snb_ivb_laptops/variants/revolve_810_g1/overridetree.cb M src/mainboard/hp/z220_sff_workstation/devicetree.cb M src/mainboard/intel/dcp847ske/devicetree.cb M src/mainboard/lenovo/s230u/devicetree.cb M src/mainboard/lenovo/t430/devicetree.cb M src/mainboard/lenovo/t440p/devicetree.cb M src/mainboard/lenovo/x131e/devicetree.cb M src/mainboard/msi/ms7707/devicetree.cb M src/mainboard/sapphire/pureplatinumh61/devicetree.cb 25 files changed, 25 insertions(+), 25 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved
diff --git a/src/mainboard/apple/macbookair4_2/devicetree.cb b/src/mainboard/apple/macbookair4_2/devicetree.cb index b9c9c15..4ecc023 100644 --- a/src/mainboard/apple/macbookair4_2/devicetree.cb +++ b/src/mainboard/apple/macbookair4_2/devicetree.cb @@ -23,7 +23,7 @@ end end
- device domain 0x0 on + device domain 0 on chip southbridge/intel/bd82x6x # Intel Series 6 Cougar Point PCH register "c2_latency" = "0x0065" register "docking_supported" = "0" diff --git a/src/mainboard/asrock/b75pro3-m/devicetree.cb b/src/mainboard/asrock/b75pro3-m/devicetree.cb index 6333c16..60816ae 100644 --- a/src/mainboard/asrock/b75pro3-m/devicetree.cb +++ b/src/mainboard/asrock/b75pro3-m/devicetree.cb @@ -22,7 +22,7 @@ device lapic 0xacac off end end end - device domain 0x0 on + device domain 0 on device pci 00.0 on subsystemid 0x1849 0x0150 end diff --git a/src/mainboard/asus/h61m-cs/devicetree.cb b/src/mainboard/asus/h61m-cs/devicetree.cb index adb39a7..3ec5e5f 100644 --- a/src/mainboard/asus/h61m-cs/devicetree.cb +++ b/src/mainboard/asus/h61m-cs/devicetree.cb @@ -10,7 +10,7 @@ device lapic 0xacac off end end end - device domain 0x0 on + device domain 0 on subsystemid 0x1043 0x844d inherit device pci 00.0 on end # Host bridge device pci 01.0 on end # PCIe Bridge for discrete graphics diff --git a/src/mainboard/asus/p8h61-m_pro/devicetree.cb b/src/mainboard/asus/p8h61-m_pro/devicetree.cb index 804f272..0491f87 100644 --- a/src/mainboard/asus/p8h61-m_pro/devicetree.cb +++ b/src/mainboard/asus/p8h61-m_pro/devicetree.cb @@ -10,7 +10,7 @@ device lapic 0xacac off end end end - device domain 0x0 on + device domain 0 on device pci 00.0 on end # Host bridge device pci 01.0 on end # PCIe bridge for discrete graphics (PCIEX16_1) device pci 02.0 on end # Internal graphics VGA controller diff --git a/src/mainboard/asus/p8z77-m_pro/devicetree.cb b/src/mainboard/asus/p8z77-m_pro/devicetree.cb index 330fa0d..1be5947 100644 --- a/src/mainboard/asus/p8z77-m_pro/devicetree.cb +++ b/src/mainboard/asus/p8z77-m_pro/devicetree.cb @@ -10,7 +10,7 @@ device lapic 0xacac off end end end - device domain 0x0 on + device domain 0 on subsystemid 0x1043 0x84ca inherit device pci 00.0 on end # Host bridge device pci 01.0 on end # PCIe Bridge for discrete graphics diff --git a/src/mainboard/compulab/intense_pc/devicetree.cb b/src/mainboard/compulab/intense_pc/devicetree.cb index 9f28a14..c678bd7 100644 --- a/src/mainboard/compulab/intense_pc/devicetree.cb +++ b/src/mainboard/compulab/intense_pc/devicetree.cb @@ -15,7 +15,7 @@ device lapic 0xacac off end end end - device domain 0x0 on + device domain 0 on device pci 00.0 on # Host bridge subsystemid 0x8086 0x2010 end diff --git a/src/mainboard/dell/optiplex_9010/devicetree.cb b/src/mainboard/dell/optiplex_9010/devicetree.cb index c805b1f..c85f2e4 100644 --- a/src/mainboard/dell/optiplex_9010/devicetree.cb +++ b/src/mainboard/dell/optiplex_9010/devicetree.cb @@ -9,7 +9,7 @@ device lapic 0xacac off end end end - device domain 0x0 on + device domain 0 on subsystemid 0x1028 0x052c inherit
device pci 00.0 on end # Host bridge Host bridge diff --git a/src/mainboard/hp/compaq_8200_elite_sff/devicetree.cb b/src/mainboard/hp/compaq_8200_elite_sff/devicetree.cb index b3b670e..8b9a093 100644 --- a/src/mainboard/hp/compaq_8200_elite_sff/devicetree.cb +++ b/src/mainboard/hp/compaq_8200_elite_sff/devicetree.cb @@ -16,7 +16,7 @@ end end
- device domain 0x0 on + device domain 0 on subsystemid 0x103c 0x1495 inherit
device pci 00.0 on end # Host bridge Host bridge diff --git a/src/mainboard/hp/folio_9480m/devicetree.cb b/src/mainboard/hp/folio_9480m/devicetree.cb index a56a48b..fca4f16 100644 --- a/src/mainboard/hp/folio_9480m/devicetree.cb +++ b/src/mainboard/hp/folio_9480m/devicetree.cb @@ -19,7 +19,7 @@ device lapic 0xacac off end end end - device domain 0x0 on + device domain 0 on subsystemid 0x103c 0x22da inherit device pci 00.0 on end # Host bridge device pci 02.0 on end # Internal graphics VGA controller diff --git a/src/mainboard/hp/snb_ivb_laptops/devicetree.cb b/src/mainboard/hp/snb_ivb_laptops/devicetree.cb index c57ffb6..4cdda4e 100644 --- a/src/mainboard/hp/snb_ivb_laptops/devicetree.cb +++ b/src/mainboard/hp/snb_ivb_laptops/devicetree.cb @@ -24,7 +24,7 @@ device lapic 0xacac off end end end - device domain 0x0 on + device domain 0 on
device pci 00.0 on end # Host bridge
diff --git a/src/mainboard/hp/snb_ivb_laptops/variants/2570p/overridetree.cb b/src/mainboard/hp/snb_ivb_laptops/variants/2570p/overridetree.cb index 216fe2e..d89492f 100644 --- a/src/mainboard/hp/snb_ivb_laptops/variants/2570p/overridetree.cb +++ b/src/mainboard/hp/snb_ivb_laptops/variants/2570p/overridetree.cb @@ -4,7 +4,7 @@ register "gpu_cpu_backlight" = "0x00000437" register "gpu_panel_power_backlight_off_delay" = "2300" register "gpu_pch_backlight" = "0x0d9c0d9c" - device domain 0x0 on + device domain 0 on subsystemid 0x103c 0x17df inherit
device pci 01.0 off end # PCIe Bridge for discrete graphics diff --git a/src/mainboard/hp/snb_ivb_laptops/variants/2760p/overridetree.cb b/src/mainboard/hp/snb_ivb_laptops/variants/2760p/overridetree.cb index 5f2adfa..d911112 100644 --- a/src/mainboard/hp/snb_ivb_laptops/variants/2760p/overridetree.cb +++ b/src/mainboard/hp/snb_ivb_laptops/variants/2760p/overridetree.cb @@ -4,7 +4,7 @@ register "gpu_cpu_backlight" = "0x00000129" register "gpu_panel_power_backlight_off_delay" = "2000" register "gpu_pch_backlight" = "0x02880288" - device domain 0x0 on + device domain 0 on subsystemid 0x103c 0x162a inherit
device pci 01.0 off end # PCIe Bridge for discrete graphics diff --git a/src/mainboard/hp/snb_ivb_laptops/variants/8460p/overridetree.cb b/src/mainboard/hp/snb_ivb_laptops/variants/8460p/overridetree.cb index 357e24a..02dc6a4 100644 --- a/src/mainboard/hp/snb_ivb_laptops/variants/8460p/overridetree.cb +++ b/src/mainboard/hp/snb_ivb_laptops/variants/8460p/overridetree.cb @@ -4,7 +4,7 @@ register "gpu_cpu_backlight" = "0x00000129" register "gpu_panel_power_backlight_off_delay" = "2000" register "gpu_pch_backlight" = "0x02880288" - device domain 0x0 on + device domain 0 on subsystemid 0x103c 0x161c inherit
device pci 01.0 on end # PCIe Bridge for discrete graphics diff --git a/src/mainboard/hp/snb_ivb_laptops/variants/8470p/overridetree.cb b/src/mainboard/hp/snb_ivb_laptops/variants/8470p/overridetree.cb index b710b25..729db13 100644 --- a/src/mainboard/hp/snb_ivb_laptops/variants/8470p/overridetree.cb +++ b/src/mainboard/hp/snb_ivb_laptops/variants/8470p/overridetree.cb @@ -4,7 +4,7 @@ register "gpu_cpu_backlight" = "0x00000385" register "gpu_panel_power_backlight_off_delay" = "2000" register "gpu_pch_backlight" = "0x0d9c0d9c" - device domain 0x0 on + device domain 0 on subsystemid 0x103c 0x179b inherit
device pci 01.0 on end # PCIe Bridge for discrete graphics diff --git a/src/mainboard/hp/snb_ivb_laptops/variants/8770w/overridetree.cb b/src/mainboard/hp/snb_ivb_laptops/variants/8770w/overridetree.cb index 7bffd68..7244acd 100644 --- a/src/mainboard/hp/snb_ivb_laptops/variants/8770w/overridetree.cb +++ b/src/mainboard/hp/snb_ivb_laptops/variants/8770w/overridetree.cb @@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-or-later
chip northbridge/intel/sandybridge - device domain 0x0 on + device domain 0 on subsystemid 0x103c 0x176c inherit
device pci 01.0 on # PCIe Bridge for discrete graphics diff --git a/src/mainboard/hp/snb_ivb_laptops/variants/folio_9470m/overridetree.cb b/src/mainboard/hp/snb_ivb_laptops/variants/folio_9470m/overridetree.cb index b8ddd69..1eb9c4c 100644 --- a/src/mainboard/hp/snb_ivb_laptops/variants/folio_9470m/overridetree.cb +++ b/src/mainboard/hp/snb_ivb_laptops/variants/folio_9470m/overridetree.cb @@ -4,7 +4,7 @@ register "gpu_cpu_backlight" = "0x00000d9c" register "gpu_panel_power_backlight_off_delay" = "2000" register "gpu_pch_backlight" = "0x0d9c0d9c" - device domain 0x0 on + device domain 0 on subsystemid 0x103c 0x18df inherit
device pci 01.0 off end # PCIe Bridge for discrete graphics diff --git a/src/mainboard/hp/snb_ivb_laptops/variants/revolve_810_g1/overridetree.cb b/src/mainboard/hp/snb_ivb_laptops/variants/revolve_810_g1/overridetree.cb index af43af7..68b6daa 100644 --- a/src/mainboard/hp/snb_ivb_laptops/variants/revolve_810_g1/overridetree.cb +++ b/src/mainboard/hp/snb_ivb_laptops/variants/revolve_810_g1/overridetree.cb @@ -4,7 +4,7 @@ register "gpu_cpu_backlight" = "0x00000263" register "gpu_panel_power_backlight_off_delay" = "2000" register "gpu_pch_backlight" = "0x02880288" - device domain 0x0 on + device domain 0 on subsystemid 0x103c 0x18f8 inherit
device pci 01.0 off end # PCIe Bridge for discrete graphics diff --git a/src/mainboard/hp/z220_sff_workstation/devicetree.cb b/src/mainboard/hp/z220_sff_workstation/devicetree.cb index d884635..fd75b1a 100644 --- a/src/mainboard/hp/z220_sff_workstation/devicetree.cb +++ b/src/mainboard/hp/z220_sff_workstation/devicetree.cb @@ -16,7 +16,7 @@ end end
- device domain 0x0 on + device domain 0 on subsystemid 0x103c 0x1791 inherit
device pci 00.0 on end # Host bridge Host bridge diff --git a/src/mainboard/intel/dcp847ske/devicetree.cb b/src/mainboard/intel/dcp847ske/devicetree.cb index 0075b94..29c188e 100644 --- a/src/mainboard/intel/dcp847ske/devicetree.cb +++ b/src/mainboard/intel/dcp847ske/devicetree.cb @@ -22,7 +22,7 @@ register "acpi_c3" = "5" end end - device domain 0x0 on + device domain 0 on device pci 00.0 on end # Host bridge device pci 01.0 off end # PCIe Bridge for discrete graphics device pci 02.0 on end # Internal graphics VGA controller diff --git a/src/mainboard/lenovo/s230u/devicetree.cb b/src/mainboard/lenovo/s230u/devicetree.cb index 9546c3e..7e96054 100644 --- a/src/mainboard/lenovo/s230u/devicetree.cb +++ b/src/mainboard/lenovo/s230u/devicetree.cb @@ -20,7 +20,7 @@ device lapic 0xacac off end end end - device domain 0x0 on + device domain 0 on subsystemid 0x17aa 0x2205 inherit
device pci 00.0 on end # Host bridge Host bridge diff --git a/src/mainboard/lenovo/t430/devicetree.cb b/src/mainboard/lenovo/t430/devicetree.cb index 3c5c3c3..146eecf 100644 --- a/src/mainboard/lenovo/t430/devicetree.cb +++ b/src/mainboard/lenovo/t430/devicetree.cb @@ -24,7 +24,7 @@ end end
- device domain 0x0 on + device domain 0 on subsystemid 0x17aa 0x21f3 inherit
chip southbridge/intel/bd82x6x # Intel Series 6 Cougar Point PCH diff --git a/src/mainboard/lenovo/t440p/devicetree.cb b/src/mainboard/lenovo/t440p/devicetree.cb index 590004a..c7af35f 100644 --- a/src/mainboard/lenovo/t440p/devicetree.cb +++ b/src/mainboard/lenovo/t440p/devicetree.cb @@ -19,7 +19,7 @@ device lapic 0xacac off end end end - device domain 0x0 on + device domain 0 on subsystemid 0x17aa 0x220e inherit
device pci 00.0 on end # Host bridge Host bridge diff --git a/src/mainboard/lenovo/x131e/devicetree.cb b/src/mainboard/lenovo/x131e/devicetree.cb index 00b5574..7ee982f 100644 --- a/src/mainboard/lenovo/x131e/devicetree.cb +++ b/src/mainboard/lenovo/x131e/devicetree.cb @@ -26,7 +26,7 @@ end end
- device domain 0x0 on + device domain 0 on subsystemid 0x17aa 0x21fe inherit
device pci 00.0 on end # Host bridge diff --git a/src/mainboard/msi/ms7707/devicetree.cb b/src/mainboard/msi/ms7707/devicetree.cb index f006e13..a5c7249 100644 --- a/src/mainboard/msi/ms7707/devicetree.cb +++ b/src/mainboard/msi/ms7707/devicetree.cb @@ -8,7 +8,7 @@ device lapic 0xacac off end end end - device domain 0x0 on + device domain 0 on subsystemid 0x1462 0x7707 inherit
device pci 00.0 on end # Host bridge diff --git a/src/mainboard/sapphire/pureplatinumh61/devicetree.cb b/src/mainboard/sapphire/pureplatinumh61/devicetree.cb index adc65cf..253e5ed 100644 --- a/src/mainboard/sapphire/pureplatinumh61/devicetree.cb +++ b/src/mainboard/sapphire/pureplatinumh61/devicetree.cb @@ -10,7 +10,7 @@ device lapic 0xacac off end end end - device domain 0x0 on + device domain 0 on chip southbridge/intel/bd82x6x # Intel Series 6 Cougar Point PCH register "c2_latency" = "0x0065" register "gen1_dec" = "0x000c0291"