Attention is currently required from: Arthur Heymans, Jérémy Compostella, Martin L Roth, Nico Huber, Werner Zeh.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81678?usp=email )
Change subject: src/arch/x86/bootblock.ld: Preserve space for the .init section
......................................................................
Patch Set 1:
(1 comment)
File src/arch/x86/bootblock.ld:
https://review.coreboot.org/c/coreboot/+/81678/comment/143f1c9e_270ed886 :
PS1, Line 33: BOOTBLOCK_TOP
This already accounts for SIZEOF(.init), see EARLYASM_SZ. I'm not sure why stuff is overflowing.
CB:81680 padds PROGRAM_SZ a bit, but I don't really know why it's needed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81678?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9256fdea98ce640bc5780b23419942266562ebb8
Gerrit-Change-Number: 81678
Gerrit-PatchSet: 1
Gerrit-Owner: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Fri, 05 Apr 2024 14:17:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment