[coreboot-gerrit] Change in coreboot[master]: mb/amd: Add Pollock CRB Cereme as Mandolin variant

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42786 )

Change subject: mb/amd: Add Pollock CRB Cereme as Mandolin variant
......................................................................

Patch Set 21:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42786/21/src/mainboard/amd/mandolin... 
File src/mainboard/amd/mandolin/variants/cereme/early_gpio.c:

https://review.coreboot.org/c/coreboot/+/42786/21/src/mainboard/amd/mandolin... 
PS21, Line 4: ../../gpio.h
> I agree that the baseboard concept is useful to keep things organized, but as it is currently implemented, things get really messy when there's multiple baseboards.

I agree. Probably because it is the first time we have a mainboard using two different baseboards (Hatch and Puff are also in a similar boat). I agree with your point that the specific case of having two baseboards under a mainboard is not still cleanly handled and there is scope for organizing things better.