[coreboot-gerrit] [M] Change in coreboot[main]: sb/intel/bd82x6x: Add CFR objects for existing options

[Angel Pons (Code Review)]

Attention is currently required from: Intel coreboot Reviewers, Matt DeVillier.

Angel Pons has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/87389?usp=email )

Change subject: sb/intel/bd82x6x: Add CFR objects for existing options
......................................................................

Patch Set 1:

(2 comments)

File src/southbridge/intel/bd82x6x/cfr.h:

https://review.coreboot.org/c/coreboot/+/87389/comment/7d62d6a7_b704d511?usp... :
PS1, Line 19: enum {
            : 	MAINBOARD_POWER_STATE_OFF = 0,
            : 	MAINBOARD_POWER_STATE_ON,
            : 	MAINBOARD_POWER_STATE_PREVIOUS,
            : };
I would've expected this enum to be defined elsewhere already

https://review.coreboot.org/c/coreboot/+/87389/comment/84e9adcd_525e3bbe?usp... :
PS1, Line 43: 0
I would add an enum for this option as the mapping is reversed (0 = enabled)