[coreboot-gerrit] Change in coreboot[master]: xeon_sp/cpx: Enable PCH thermal device via FSP

[Johnny Lin (Code Review)]

Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44075 )

Change subject: xeon_sp/cpx: Enable PCH thermal device via FSP
......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/c/coreboot/+/44075/2/src/mainboard/ocp/deltalake... 
File src/mainboard/ocp/deltalake/romstage.c:

https://review.coreboot.org/c/coreboot/+/44075/2/src/mainboard/ocp/deltalake... 
PS2, Line 53: 	mupd->FspmConfig.ThermalDeviceEnable = 1;
> I was thinking of doing something like CB:42557

Yes, it's 0:14.2 PCH thermal subsystem, updated to follow CB:42557. Thanks for the tips.

https://review.coreboot.org/c/coreboot/+/44075/3/src/mainboard/ocp/deltalake... 
File src/mainboard/ocp/deltalake/romstage.c:

https://review.coreboot.org/c/coreboot/+/44075/3/src/mainboard/ocp/deltalake... 
PS3, Line 15: static const config_t *config = NULL;
> This should not be needed if doing something like CB:42557

I changed to follow CB:42557