HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25600 )
Change subject: nb/intel/i945: Use parallel MP init
......................................................................
Patch Set 40: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/25600/40/src/cpu/intel/model_f4x/model_f4x_i...
File src/cpu/intel/model_f4x/model_f4x_init.c:
https://review.coreboot.org/#/c/25600/40/src/cpu/intel/model_f4x/model_f4x_i...
PS40, Line 27: if (!IS_ENABLED(CONFIG_PARALLEL_MP) && !intel_ht_sibling()) {
: /* MTRRs are shared between threads */
: x86_setup_mtrrs();
: x86_mtrr_check();
:
: /* Update the microcode */
: intel_update_microcode_from_cbfs();
: }
please, why don't you drop this and "intel_sibling_init(cpu)" ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/25600
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I955551b99e9cbc397f99c2a6bd355c6070390bcb
Gerrit-Change-Number: 25600
Gerrit-PatchSet: 40
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 16 Jan 2019 15:59:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment