Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36770 )
Change subject: mb/asrock: add Asrock B85M Pro4
......................................................................
Patch Set 4:
Patch Set 4:
Forgot to mention: the integrated Intel network device does not appear on PCI at all, so this needs to be addressed. Also documentation is missing.
If you want the GbE device on the Intel PCH, you need .enable_gbe=1 in pei_data.
You mean 'gbe_enable' I guess? Just saw that in the struct definition. I wonder why it was left out on the asrock h81m-hds.
Thanks for the tip!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36770
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I10a16dfc56f2aa88648c8aaaba4feab40c491504
Gerrit-Change-Number: 36770
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Iru Cai (vimacs)
mytbk920423@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 20 Nov 2019 15:50:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment