Elyes Haouas has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83217?usp=email )
Change subject: device/azalia_device.c: Use `azalia_enter_reset()` ......................................................................
device/azalia_device.c: Use `azalia_enter_reset()`
Use the existing `azalia_enter_reset()` function instead of explicitly clearing the bit (and having to explain in a comment what this means).
Change-Id: I04924e68420a93a1ad46f5a7ab359e38c0f7e210 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/83217 Reviewed-by: Felix Singer service+coreboot-gerrit@felixsinger.de Reviewed-by: Elyes Haouas ehaouas@noos.fr Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/device/azalia_device.c 1 file changed, 1 insertion(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Nico Huber: Looks good to me, approved Elyes Haouas: Looks good to me, approved
diff --git a/src/device/azalia_device.c b/src/device/azalia_device.c index 8051f2e..02bbf89 100644 --- a/src/device/azalia_device.c +++ b/src/device/azalia_device.c @@ -96,8 +96,7 @@
no_codec: /* Codec Not found */ - /* Put HDA back in reset (BAR + 0x8) [0] */ - azalia_set_bits(base + HDA_GCTL_REG, 1, 0); + azalia_enter_reset(base); printk(BIOS_DEBUG, "azalia_audio: no codec!\n"); return 0; }