Attention is currently required from: Nico Huber, Patrick Rudolph.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56252 )
Change subject: soc/skylake: Make VT-d controllable from CMOS option
......................................................................
Patch Set 7:
(2 comments)
File src/soc/intel/skylake/systemagent.c:
https://review.coreboot.org/c/coreboot/+/56252/comment/935355bc_5c2db4f4
PS6, Line 18: bool soc_is_vtd_capable(void)
Could we rename this to make it clear that it does more now? e.g. […]
Done
https://review.coreboot.org/c/coreboot/+/56252/comment/9e383fb8_eaf0192c
PS6, Line 23: (!vtd) & VTD_DISABLE)
Isn't this part constant 0? […]
Thanks :)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56252
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1aea14968e08ee6af822bd259ca1d462f8926994
Gerrit-Change-Number: 56252
Gerrit-PatchSet: 7
Gerrit-Owner: Sean Rhodes
admin@starlabs.systems
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 15 Oct 2021 10:35:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment