Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47902 )
Change subject: mb/google/zork: Update SPD table for Shuboz
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47902/1/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/shuboz/spd/mem_parts_used.txt:
https://review.coreboot.org/c/coreboot/+/47902/1/src/mainboard/google/zork/v...
PS1, Line 10: 0
Hi Furquan, […]
Yes, the tool optimizes the ID allocation to ensure that we use generic SPDs and allocate the same ID for all parts with same characteristics. So, we should let the tool do the ID allocation and not use fixed IDs.
Have you already built devices with the fixed IDs here? Or is this being done for an upcoming build?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47902
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f5f875daab58343f1cc8a9327ea128ba5e1f050
Gerrit-Change-Number: 47902
Gerrit-PatchSet: 2
Gerrit-Owner: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-Comment-Date: Thu, 26 Nov 2020 03:28:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-MessageType: comment