Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33738 )
Change subject: device/Kconfig: Add HAVE_EXT_GFX kconfig
......................................................................
Patch Set 8:
Patch Set 8: Code-Review-1
(1 comment)
-1 as the introduced Kconfig options has no benefit and only confuses users.
It increases fragmentation and depends on board specific code for no reason.
external GFX card over PCIE is board specific right then what the problem if board select that option ?
It mixes preferred GPU selection on multi GPU setup platforms with legacy graphics initialisation features in coreboot.
sorry, i don't understand the issue here ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33738
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8ebde69e38defbe3321eb5e5bbd632c209ae2cd8
Gerrit-Change-Number: 33738
Gerrit-PatchSet: 8
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 08 Jul 2019 15:05:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment