Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32297 )
Change subject: soc/intel/cannonlake: Enable PlatformDebugConsent by Kconfig
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/#/c/32297/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32297/4//COMMIT_MSG@10
PS4, Line 10: y
not true anymore.
done.
thank you
https://review.coreboot.org/#/c/32297/4/src/soc/intel/cannonlake/romstage/fs...
File src/soc/intel/cannonlake/romstage/fsp_params.c:
https://review.coreboot.org/#/c/32297/4/src/soc/intel/cannonlake/romstage/fs...
PS4, Line 115:
Get rid of this too: https://review.coreboot.org/cgit/coreboot. […]
done
thank you
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32297
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib845b5e42bc78fb352a0c97c6301f2aeca522f29
Gerrit-Change-Number: 32297
Gerrit-PatchSet: 5
Gerrit-Owner: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Tue, 16 Apr 2019 05:48:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment