Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44397 )
Change subject: mb/google/dedede: Replace static Camera ACPI by driver for WDoo ......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44397/9/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44397/9/src/mainboard/google/dedede... PS9, Line 185: 0
I know this was copied from the asl, but I suspect there's a decent chance there already is (or will […]
the drivers/spi/acpi driver (for cr50) will just use the UID it was given (or defaulted to 0), which is 0 in this case, so you would need a different UID.
https://review.coreboot.org/c/coreboot/+/44397/9/src/mainboard/google/dedede... PS9, Line 229: "GPP_D13" #power_enable_2p8 : register "gpio_panel.gpio[1].gpio_num" = "GPP_D14"
I didn't follow the ref-counting change but I'm assuming it's doing some ref-counting on D13 and D14 […]
Yes, it should work exactly that way. There is a static variable in the mipi_camera driver storing the _OFF and _ON resources, and if one (e.g. GPP_D13) is already found in that cache, it will reuse the guard variable/method.