[coreboot-gerrit] Change in coreboot[master]: mb/google/dedede: Add ACPI support for camera in WDee

[Varshit B Pandya (Code Review)]

Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42205 )

Change subject: mb/google/dedede: Add ACPI support for camera in WDee
......................................................................

Patch Set 20:

(3 comments)
> Patch Set 19:
>
> (1 comment)
>
> This change is ready for review.

My WDee with rework has went down, will verify this patch with Evan's patch and update the commit message with the test results soon.

https://review.coreboot.org/c/coreboot/+/42205/19/src/mainboard/google/deded... 
File src/mainboard/google/dedede/variants/waddledee/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/42205/19/src/mainboard/google/deded... 
PS19, Line 136: 15.3 on # I2C 3
> For reference, see: https://buganizer.corp.google. […]

Ack

https://review.coreboot.org/c/coreboot/+/42205/19/src/mainboard/google/deded... 
PS19, Line 184: ""\_SB.PCI0.I2C5.CAM1.PRIC""
> Why VCM for UFC is using Power Resource for WFC? Is that expected or am I understanding it incorrect […]

Updated

https://review.coreboot.org/c/coreboot/+/42205/19/src/mainboard/google/deded... 
PS19, Line 197: 				register "pr0" = ""\_SB.PCI0.I2C3.CAM1.PRIC""
> Thanks. […]

if physically they share the same power source how can they be powered on/off separately? can you please elaborate.
I think _DSM and SSDB method are used by the windows driver, They are generated by the SSDT logic, I'll confirm it.