Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45987 )
Change subject: amd/picasso/verstage: replace rsa accel with modexp
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45987/4/src/soc/amd/picasso/psp_ver...
File src/soc/amd/picasso/psp_verstage/vboot_crypto.c:
https://review.coreboot.org/c/coreboot/+/45987/4/src/soc/amd/picasso/psp_ver...
PS4, Line 132: sig_swapped[i] = swab32(inout_32[key->arrsize - i - 1]);
AFAIK no.
Yes, do not read the hardware buffer from the PSP as an array of bytes when it shall be interpreted as an array of dwords. This might be cumbersome to implement, though.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45987
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I085f043bf2014615d2c9db6df0b7947ee84b9546
Gerrit-Change-Number: 45987
Gerrit-PatchSet: 5
Gerrit-Owner: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 05 Oct 2020 16:25:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kangheui Won
khwon@chromium.org
Comment-In-Reply-To: Eric Peers
epeers@google.com
Gerrit-MessageType: comment