Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35489 )
Change subject: sb/nvidia/{ck804,mcp55}: Use new device references for MAC EEPROM ......................................................................
Patch Set 1: Code-Review+1
(3 comments)
Looks good
https://review.coreboot.org/c/coreboot/+/35489/1/src/mainboard/supermicro/h8... File src/mainboard/supermicro/h8dmr_fam10/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35489/1/src/mainboard/supermicro/h8... PS1, Line 106: mac "mac" alone is pretty short and confusing... What about "mac_dev"? I can't really find a name that I like a lot, so if nothing better comes up, it's not a big deal
https://review.coreboot.org/c/coreboot/+/35489/1/src/mainboard/supermicro/h8... PS1, Line 136: use mac as mac_eeprom Other than the "mac" name issue, WONDERFUL! I LOVE IT!
https://review.coreboot.org/c/coreboot/+/35489/1/src/southbridge/nvidia/mcp5... File src/southbridge/nvidia/mcp55/nic.c:
PS1: Eww... The code style... IT HURTS!
But I don't need to look at these files, so I don't care in the slightest.