Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33425 )
Change subject: qcs405: Add support for specifying mbn_version ......................................................................
Patch Set 5:
(7 comments)
https://review.coreboot.org/c/coreboot/+/33425/5/util/qualcomm/createxbl.py File util/qualcomm/createxbl.py:
https://review.coreboot.org/c/coreboot/+/33425/5/util/qualcomm/createxbl.py@... PS5, Line 125: '5' or '6'" or '3'
https://review.coreboot.org/c/coreboot/+/33425/5/util/qualcomm/createxbl.py@... PS5, Line 217: is_ext_mbn_v5 = True Again, you can remove this variable now. (You said "Done" but it's still here.)
https://review.coreboot.org/c/coreboot/+/33425/5/util/qualcomm/mbn_tools.py File util/qualcomm/mbn_tools.py:
https://review.coreboot.org/c/coreboot/+/33425/5/util/qualcomm/mbn_tools.py@... PS5, Line 78: FLASH_PARTI_VERSION = 3 # Flash Partition Version Number Should remove this and use header_version everywhere.
https://review.coreboot.org/c/coreboot/+/33425/5/util/qualcomm/mbn_tools.py@... PS5, Line 1006: Should we maybe also assert that header version is one of the supported values (3, 5 or 6) somewhere around here, just to be sure?
https://review.coreboot.org/c/coreboot/+/33425/5/util/qualcomm/mbn_tools.py@... PS5, Line 1007: if is_ext_mbn_v5 == True: This should check header_version == VERSION_5 instead.
https://review.coreboot.org/c/coreboot/+/33425/5/util/qualcomm/mbn_tools.py@... PS5, Line 1009: boot_header.flash_parti_ver = VERSION_5 # version Just do flash_parti_ver = header_version once outside the conditional.
https://review.coreboot.org/c/coreboot/+/33425/5/util/qualcomm/mbn_tools.py@... PS5, Line 1050: is_sha384_algo = False Unused?